• [web][audio] Support preloading #43063
• [android][audio] Support native preloading #43062
• [ios][audio] Support native preloading #43061 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

The Pull Request introduced fingerprint changes against the base commit: a88fab5

[
  {
    "op": "changed",
    "beforeSource": {
      "type": "dir",
      "filePath": "../../packages/expo-audio/ios",
      "reasons": [
        "expoAutolinkingIos"
      ],
      "hash": "7483c01f05528676ffaddc1106f124e14532de18"
    },
    "afterSource": {
      "type": "dir",
      "filePath": "../../packages/expo-audio/ios",
      "reasons": [
        "expoAutolinkingIos"
      ],
      "hash": "dc19b7c91768bb26b185907ae492b2b994b718af"
    }
  }
]

Generated by PR labeler 🤖

Subscribed to pull request

Generated by CodeMention

@alanjhughes thanks for working on this!

I want to mention that audio has prop isLoaded:

https://docs.expo.dev/versions/latest/sdk/audio/#isloaded

which is kinda useless (it doesnt really show audio is ready to play)

and there is isBuffering:

https://docs.expo.dev/versions/latest/sdk/audio/#isbuffering

which works in way you cannot rely on it.

So maybe add another status prop like isBufferedToPlay to indicate that player will play asap with minimum latency (some or all data is really buffered).

Because of this, neither isLoaded nor isBuffering are currently not suitable for case "when?" you can play audio.

@psnet

So maybe add another status prop like isBufferedToPlay to indicate that player will play asap with minimum latency (some or all data is really buffered).

What values outside of what we are already using are provided by the native SDKs would be used to determine that?

@alanjhughes

What values outside of what we are already using are provided by the native SDKs would be used to determine that?

Right now I dont know, I just want to mention that current statuses isLoaded and isBuffering are not really helpful. And asked maybe you have ideas how to improve this case?

@psnet - Ok, I will try out some things and see if this can be improved

@psnet - you can also check the playbackState for readyToPlay

@alanjhughes

@psnet - you can also check the playbackState for readyToPlay

on web it is unimplemented (always empty):

https://github.com/expo/expo/blob/main/packages/expo-audio/src/AudioModule.web.ts#L89

on android:

it is the same as isBuffering:

and as isLoaded:

Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines.

I've found some issues in your pull request that should be addressed (click on them for more details) 👇

Generated by ExpoBot 🤖 against bc10a3f

Merge activity

• Feb 19, 11:54 AM UTC: A user started a stack merge that includes this pull request via Graphite.
• Feb 19, 11:54 AM UTC: @alanjhughes merged this pull request with Graphite.