Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
3 tasks
Contributor
|
Subscribed to pull request
Generated by CodeMention |
Kudo
approved these changes
Dec 3, 2025
Contributor
Author
350ac45 to
bbaf3fd
Compare
Collaborator
|
Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines. I've found some issues in your pull request that should be addressed (click on them for more details) 👇
|
Collaborator
|
The Pull Request introduced fingerprint changes against the base commit: bc2e754 Fingerprint diff[
{
"op": "changed",
"beforeSource": {
"type": "dir",
"filePath": "../../packages/expo-modules-core",
"reasons": [
"expoAutolinkingIos",
"expoAutolinkingAndroid",
"expoAutolinkingIos"
],
"hash": "e548f3590f55781d349964972ed50475675533fc"
},
"afterSource": {
"type": "dir",
"filePath": "../../packages/expo-modules-core",
"reasons": [
"expoAutolinkingIos",
"expoAutolinkingAndroid",
"expoAutolinkingIos"
],
"hash": "7a7c1d05c6b0afcac921753a366523e572ec704e"
}
}
]Generated by PR labeler 🤖 |
Kudo
pushed a commit
that referenced
this pull request
Dec 4, 2025
) # Why This PR improves the way selectors are referenced in `ExpoAppDelegateSubscriberManager.swift` by using explicit selector references to protocol methods instead of using string-based selectors. This approach is more type-safe. # How Updated all selector references in `ExpoAppDelegateSubscriberManager.swift` to use explicit protocol method references: - Changed selector references like `#selector(application(_:willFinishLaunchingWithOptions:))` to `#selector(UIApplicationDelegate.application(_:willFinishLaunchingWithOptions:))` - Replaced string-based selectors using `NSSelectorFromString` with `#selector` syntax - Made similar changes for both UIKit (iOS) and AppKit (macOS) application delegate methods but I _did not test macos_! # Test Plan - green CI # Checklist - [ ] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) (cherry picked from commit ad35242)
aleqsio
pushed a commit
that referenced
this pull request
Dec 5, 2025
) # Why This PR improves the way selectors are referenced in `ExpoAppDelegateSubscriberManager.swift` by using explicit selector references to protocol methods instead of using string-based selectors. This approach is more type-safe. # How Updated all selector references in `ExpoAppDelegateSubscriberManager.swift` to use explicit protocol method references: - Changed selector references like `#selector(application(_:willFinishLaunchingWithOptions:))` to `#selector(UIApplicationDelegate.application(_:willFinishLaunchingWithOptions:))` - Replaced string-based selectors using `NSSelectorFromString` with `#selector` syntax - Made similar changes for both UIKit (iOS) and AppKit (macOS) application delegate methods but I _did not test macos_! # Test Plan - green CI # Checklist - [ ] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This PR improves the way selectors are referenced in
ExpoAppDelegateSubscriberManager.swiftby using explicit selector references to protocol methods instead of using string-based selectors. This approach is more type-safe.How
Updated all selector references in
ExpoAppDelegateSubscriberManager.swiftto use explicit protocol method references:#selector(application(_:willFinishLaunchingWithOptions:))to#selector(UIApplicationDelegate.application(_:willFinishLaunchingWithOptions:))NSSelectorFromStringwith#selectorsyntaxTest Plan
Checklist
changelog.mdentry and rebuilt the package sources according to this short guidenpx expo prebuild& EAS Build (eg: updated a module plugin).