Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
The Pull Request introduced fingerprint changes against the base commit: 4df9160 Fingerprint diff[
{
"op": "changed",
"beforeSource": {
"type": "dir",
"filePath": "../../packages/expo-modules-core",
"reasons": [
"expoAutolinkingIos",
"expoAutolinkingAndroid",
"expoAutolinkingIos"
],
"hash": "0ea8b2ac87a722a59e9bafc5ce85bd9e0859525a"
},
"afterSource": {
"type": "dir",
"filePath": "../../packages/expo-modules-core",
"reasons": [
"expoAutolinkingIos",
"expoAutolinkingAndroid",
"expoAutolinkingIos"
],
"hash": "8362a211dc3270df9e9a17008f20d7ab17ce4900"
}
}
]Generated by PR labeler 🤖 |
18779ac to
f3a12d9
Compare
|
Subscribed to pull request
Generated by CodeMention |
| } | ||
| } | ||
|
|
||
| final class ExpoAppDelegateSubscriberManagerSpec: ExpoSpec { |
There was a problem hiding this comment.
I hope it's not too much effort at this point, could you use Swift Testing instead of Quick/Nimble? We're moving away from the latter to get rid of additional 3rd-party dependencies.
Here is one good example: https://github.com/expo/expo/blob/main/packages/expo-modules-core/ios/Tests/AsyncFunctionTests.swift
|
Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines. I've found some issues in your pull request that should be addressed (click on them for more details) 👇
|
| let subscriber = MockAppDelegateSubscriber() | ||
|
|
||
| init() { | ||
| ExpoAppDelegateSubscriberRepository.registerSubscriber(subscriber) |
There was a problem hiding this comment.
not strictly necessary, but might be cleaner to also have a removeSubsriber method.
now the ExpoAppDelegateSubscriberRepository ends up adding one subscriber for each test
…rding (#41376) # Why Follow-up to #40008 which caused #37401 which was then fixed by #41185. To have confidence in app delegate subscribers, this PR adds tests for `ExpoAppDelegateSubscriberManager`. # How Creates a dummy app delegate subscriber, registers it with `ExpoAppDelegateSubscriberRepository` and then calls the static methods on `ExpoAppDelegateSubscriberManager` which should be forwarded to the dummy app delegate subscriber (which we verify). # Test Plan - green CI # Checklist <!-- Please check the appropriate items below if they apply to your diff. --> - [ ] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
…rding (#41376) # Why Follow-up to #40008 which caused #37401 which was then fixed by #41185. To have confidence in app delegate subscribers, this PR adds tests for `ExpoAppDelegateSubscriberManager`. # How Creates a dummy app delegate subscriber, registers it with `ExpoAppDelegateSubscriberRepository` and then calls the static methods on `ExpoAppDelegateSubscriberManager` which should be forwarded to the dummy app delegate subscriber (which we verify). # Test Plan - green CI # Checklist <!-- Please check the appropriate items below if they apply to your diff. --> - [ ] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
Why
Follow-up to #40008 which caused #37401 which was then fixed by #41185. To have confidence in app delegate subscribers, this PR adds tests for
ExpoAppDelegateSubscriberManager.How
Creates a dummy app delegate subscriber, registers it with
ExpoAppDelegateSubscriberRepositoryand then calls the static methods onExpoAppDelegateSubscriberManagerwhich should be forwarded to the dummy app delegate subscriber (which we verify).Test Plan
Checklist
changelog.mdentry and rebuilt the package sources according to this short guidenpx expo prebuild& EAS Build (eg: updated a module plugin).