[android][ui] Add icons to ContextMenu and trailingIcon to Button#39095
Merged
[android][ui] Add icons to ContextMenu and trailingIcon to Button#39095
Conversation
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
…context_menu # Conflicts: # packages/expo-ui/CHANGELOG.md
…' has no properties in common with type 'IntrinsicAttributes'.
Contributor
|
Subscribed to pull request
Generated by CodeMention |
Contributor
|
I'd like to standardise on a name (either leadingIcon and leadingImage), and I think going with icon makes more sense here |
Contributor
Author
Yes, totally, I'll change that! Edit: actually, I was already using icon instead of image, but I accidentally wrote image in the PR description.. I fixed that, my bad! Should be good to merge now @aleqsio ! |
…context_menu # Conflicts: # packages/expo-ui/CHANGELOG.md
# Conflicts: # packages/expo-ui/CHANGELOG.md # packages/expo-ui/build/jetpack-compose/Button/index.js # packages/expo-ui/build/jetpack-compose/Button/index.js.map # packages/expo-ui/build/jetpack-compose/Button/types.js.map # packages/expo-ui/build/jetpack-compose/ContextMenu/index.js # packages/expo-ui/build/jetpack-compose/ContextMenu/index.js.map # packages/expo-ui/build/jetpack-compose/ContextMenu/utils.js # packages/expo-ui/build/jetpack-compose/ContextMenu/utils.js.map
intergalacticspacehighway
approved these changes
Sep 12, 2025
Kudo
requested changes
Sep 14, 2025
Contributor
Kudo
left a comment
There was a problem hiding this comment.
sorry have you resolving conflicts multiple times. the pr looks good. after resolving the changelog, please re-request review for me and i'll approve and merge the pr. thank you
amandeepmittal
requested changes
Sep 15, 2025
…context_menu # Conflicts: # packages/expo-ui/CHANGELOG.md
Wenszel
pushed a commit
that referenced
this pull request
Sep 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
systemImageprop, however, it is useful to be able to place an image in a button either before or after the text. This PR deprecates thesystemImageprop and introducesleadingIconandtrailingIconinsteadleadingIconandtrailingIconfor ContextMenu items.Demo
expo-ui-context-menu-icons.mp4
Test Plan
See the test screens for Button and ContextMenu in native-component-list, with the
bare-expoapp, on an Android device.See also
Checklist
changelog.mdentry and rebuilt the package sources according to this short guidenpx expo prebuild& EAS Build (eg: updated a module plugin).