[android][ui] text input leading and trailing icons#38147
Open
mateoguzmana wants to merge 10 commits intoexpo:mainfrom
Open
[android][ui] text input leading and trailing icons#38147mateoguzmana wants to merge 10 commits intoexpo:mainfrom
mateoguzmana wants to merge 10 commits intoexpo:mainfrom
Conversation
4d68518 to
55c91fd
Compare
Contributor
|
Subscribed to pull request
Generated by CodeMention |
aleqsio
reviewed
Jul 22, 2025
aleqsio
approved these changes
Jul 24, 2025
3 tasks
Contributor
Author
|
@aleqsio, is there anything I can help with to push this forward? (other than solving conflicts) |
Contributor
|
I'm good with merging this once we resolve conflicts – feel free to tag me again then |
Contributor
Author
|
@aleqsio, I think it should be good to go now. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Compose TextField has options to render leading and trailing icons.
How
Created two new props,
leadingIconandtrailingIcon, which accept a material icon name.The Button component was already rendering an icon, which allowed to extract that piece and reuse it for the new props.
Test Plan
Checklist
changelog.mdentry and rebuilt the package sources according to this short guide