This repository was archived by the owner on Aug 2, 2021. It is now read-only.
chunk, storage: storage with multi chunk Set method#1684
Merged
Conversation
acud
approved these changes
Aug 25, 2019
Contributor
acud
left a comment
There was a problem hiding this comment.
LGTM except a few more comments about the cases would be nice
| item.StoreTimestamp = i.StoreTimestamp | ||
| item.BinID = i.BinID | ||
| case leveldb.ErrNotFound: | ||
| db.pushIndex.DeleteInBatch(batch, item) |
Contributor
There was a problem hiding this comment.
can you explain a bit better the case here? if it isn't in the retrieval data index does this not infer that the index is corrupted?
Member
Author
There was a problem hiding this comment.
Yes, this case can happen only if the chunk is removed by gc in between it is got from localstore and its access time is set. In that case, the error would not be relevant. Maybe we could do something else in this case? Maybe just return nil?
zelig
approved these changes
Aug 26, 2019
26 tasks
chadsr
added a commit
to chadsr/swarm
that referenced
this pull request
Sep 23, 2019
* 'master' of github.com:ethersphere/swarm: pss: Modularize crypto and remove Whisper. Step 1 - isolate whisper code (ethersphere#1698) pss: Improve pressure backstop queue handling - no mutex (ethersphere#1695) cmd/swarm-snapshot: if 2 nodes to create snapshot use connectChain (ethersphere#1709) network: Add API for Capabilities (ethersphere#1675) pss: fixed flaky test that was using a global variable instead of a local one (ethersphere#1702) pss: Port tests to `network/simulation` (ethersphere#1682) storage: fix hasherstore seen check to happen when error is nil (ethersphere#1700) vendor: upgrade go-ethereum to 1.9.2 (ethersphere#1689) bzzeth: initial support for bzz-eth protocol (ethersphere#1571) network/stream: terminate runUpdateSyncing on peer quit (ethersphere#1696) all: first working SWAP version (ethersphere#1554) version: update to v0.5.0 unstable (ethersphere#1694) chunk, storage: storage with multi chunk Set method (ethersphere#1684) chunk, storage: add HasMulti to chunk.Store (ethersphere#1686) chunk, shed, storage: chunk.Store GetMulti method (ethersphere#1691) api, chunk: progress bar support (ethersphere#1649)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes chunk.Store Set method to accept multiple chunks. This PR is a followup of #1681. This is a performance improvement by using one leveldb batch for multiple chunks, instead to have a separate batch for every chunk.
All localstore Set tests are changed to validate functionality with multiple chunks.