Skip to content

Add optional gas reporting to unit test run#626

Merged
gakonst merged 3 commits intomasterfrom
maintenance/gas-costs-report
Apr 28, 2021
Merged

Add optional gas reporting to unit test run#626
gakonst merged 3 commits intomasterfrom
maintenance/gas-costs-report

Conversation

@elenadimitrova
Copy link
Copy Markdown

@elenadimitrova elenadimitrova commented Apr 26, 2021

Description
Adds hardhat-gas-reporter package and base configuration to unit and integration test runs. Disabled by default, enabled via ENABLE_GAS_REPORT environment variable.

Note that I investigated using codechecks for better report presentation and also benchmarking gas cost diff against master in CI however the owner of that krzkaczor said it's going be decommissioned in near future so didn't want to integrate us with "abandonware" :)

Metadata
Resulted from investigating issue #500 and the need to benchmark gas costs on L1

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 26, 2021

⚠️ No Changeset found

Latest commit: 02ee5e5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@elenadimitrova elenadimitrova self-assigned this Apr 26, 2021
@elenadimitrova elenadimitrova force-pushed the maintenance/gas-costs-report branch 15 times, most recently from 5e3f27c to d9dd203 Compare April 27, 2021 13:32
@elenadimitrova elenadimitrova marked this pull request as ready for review April 27, 2021 18:53
@gakonst gakonst force-pushed the maintenance/gas-costs-report branch from d9dd203 to 02ee5e5 Compare April 27, 2021 19:31
Copy link
Copy Markdown
Contributor

@gakonst gakonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great change.

@gakonst gakonst merged commit f33d11e into master Apr 28, 2021
@gakonst gakonst deleted the maintenance/gas-costs-report branch April 28, 2021 07:31
InoMurko pushed a commit to omgnetwork/optimism that referenced this pull request May 25, 2021
* Add hardhat-gas-reporter package and base config

* Generate an output file from gas reporter when run in CI
Selectively enable gas reporter based on ENABLE_GAS_REPORT env var

* Add gas reports to integration tests
theochap pushed a commit that referenced this pull request Dec 10, 2025
Co-authored-by: github-merge-queue <118344674+github-merge-queue@users.noreply.github.com>
emhane pushed a commit that referenced this pull request Feb 4, 2026
emhane pushed a commit that referenced this pull request Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants