Conversation
|
I'm not sure if removing geth's genesis block is a long term solution to the problem mentioned in the comments. How would genesis state exist without it? |
|
After thinking about it a bit more, it technically would be possible to remove the genesis block from geth, but i think it would involve touching a lot of code paths. I think it would be easier to add a "genesis" block to the contracts or (more work) have a custom non fork of geth that uses geth as a library to implement exactly only what we need |
|
@tynes ah yeah another option is have I think for now my sense is we just don't fix this issue & we leave these @tynes do your Geth changes assert that |
* tests: Improve coverage for StateTransitionerFactory * fix failing test because of missing contract Co-authored-by: Maurelian <maurelian@protonmail.ch>
…365) Migrates `op-alloy-provider` to `op-rs/maili-provider`. Re-exports `maili-provider::*`.
Reverts migrating `OpEngineApi` that originates from l1. Adds OP-unique `EngineExtApi` as super trait. Blocked by release of op-rs/maili#48
) Reverts migrating `OpEngineApi` that originates from l1. Adds OP-unique `EngineExtApi` as super trait. Blocked by release of op-rs/maili#48
Description
Tested the batch submitter against L1 and made a few fixes which solved the remaining issues. This should allow the batch submitter to be run against testnet without an issue.
Note
The
lastL1BlockNumberlogic is very dumb and should be replaced ASAP with the correct logic added to L2Geth.Metadata
Fixes
Contributing Agreement