Skip to content

Fix batch submitter#365

Merged
karlfloersch merged 4 commits intomasterfrom
fix/batch_submitter
Nov 19, 2020
Merged

Fix batch submitter#365
karlfloersch merged 4 commits intomasterfrom
fix/batch_submitter

Conversation

@karlfloersch
Copy link
Copy Markdown
Contributor

Description

Tested the batch submitter against L1 and made a few fixes which solved the remaining issues. This should allow the batch submitter to be run against testnet without an issue.

Note

The lastL1BlockNumber logic is very dumb and should be replaced ASAP with the correct logic added to L2Geth.

Metadata

Fixes

Contributing Agreement

@tynes
Copy link
Copy Markdown
Contributor

tynes commented Nov 19, 2020

I'm not sure if removing geth's genesis block is a long term solution to the problem mentioned in the comments. How would genesis state exist without it?

@tynes
Copy link
Copy Markdown
Contributor

tynes commented Nov 19, 2020

After thinking about it a bit more, it technically would be possible to remove the genesis block from geth, but i think it would involve touching a lot of code paths. I think it would be easier to add a "genesis" block to the contracts or (more work) have a custom non fork of geth that uses geth as a library to implement exactly only what we need

@karlfloersch
Copy link
Copy Markdown
Contributor Author

@tynes ah yeah another option is have getTotalElements() return totalElements+1.

I think for now my sense is we just don't fix this issue & we leave these +1 and -1s even though it's not super clean. It doesn't seem worth it at this point to add custom logic to the contracts just to handle a weird case that isn't even a requirement to handle. Oh another option is instead of removing the genesis block, we just add an empty transaction at the genesis.

@tynes do your Geth changes assert that tx index == block number? In that case I can just add special logic to handle the first block where submit an empty transaction

@karlfloersch karlfloersch merged commit ded9513 into master Nov 19, 2020
@gakonst gakonst deleted the fix/batch_submitter branch March 18, 2021 15:03
snario pushed a commit that referenced this pull request Apr 14, 2021
* tests: Improve coverage for StateTransitionerFactory

* fix failing test because of missing contract

Co-authored-by: Maurelian <maurelian@protonmail.ch>
bap2pecs pushed a commit to babylonlabs-io/optimism that referenced this pull request Jul 31, 2024
agusduha added a commit that referenced this pull request Apr 10, 2025
theochap pushed a commit that referenced this pull request Dec 10, 2025
theochap pushed a commit that referenced this pull request Jan 15, 2026
…365)

Migrates `op-alloy-provider` to `op-rs/maili-provider`. Re-exports
`maili-provider::*`.
theochap pushed a commit that referenced this pull request Jan 15, 2026
Reverts migrating `OpEngineApi` that originates from l1. Adds OP-unique
`EngineExtApi` as super trait.

Blocked by release of op-rs/maili#48
theochap pushed a commit that referenced this pull request Jan 21, 2026
)

Reverts migrating `OpEngineApi` that originates from l1. Adds OP-unique
`EngineExtApi` as super trait.

Blocked by release of op-rs/maili#48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants