This repository was archived by the owner on Feb 21, 2025. It is now read-only.
chore(provider): Shrink scope of OpEngineApi to encompass only non-l1 methods#48
Merged
chore(provider): Shrink scope of OpEngineApi to encompass only non-l1 methods#48
OpEngineApi to encompass only non-l1 methods#48Conversation
OpEngineApi to encompass only non-l1 methods
refcell
approved these changes
Jan 12, 2025
github-merge-queue bot
pushed a commit
to alloy-rs/op-alloy
that referenced
this pull request
Jan 13, 2025
Reverts migrating `OpEngineApi` that originates from l1. Adds OP-unique `EngineExtApi` as super trait. Blocked by release of op-rs/maili#48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ideally, alloy would divide the
EngineApitrait intoEngineApiV1,EngineApiV2, etc. However since this is not the case atm,OpEngineApican't haveEngineApias super trait since it doesn't support V1. Nonetheless, these methods aren't unique to l2, and hence better move back to op-alloy, leaving only OP unique methodengine_signalSuperchainV1in maili for now.op_alloy_provider::OpEngineApishould havemaili_provider::EngineExtApias supertrait.We may want to rename this crate or move the trait into protocol?