Merged
Conversation
| "patch": "yarn run patch:ganache && yarn run patch:waffle", | ||
| "patch:ganache": "rm node_modules/ganache-core/typings/index.d.ts ||:", | ||
| "patch:waffle": "sed -ie 's!Ganache.GanacheOpts!any!g' node_modules/ethereum-waffle/dist/waffle.d.ts" | ||
| "patch:waffle": "sed -ie 's!Ganache.GanacheOpts!any!g' node_modules/ethereum-waffle/dist/waffle.d.ts ||:" |
| b.stateRoot = block.stateRoot | ||
| for (let i = 0; i < b.transactions.length; i++) { | ||
| b.transactions[i].l1BlockNumber = block.transactions[i].l1BlockNumber | ||
| if (b.transactions[i].l1BlockNumber != null) { |
Contributor
There was a problem hiding this comment.
What happens if this is null?
karlfloersch
reviewed
Nov 4, 2020
| for (let i = 0; i < b.transactions.length; i++) { | ||
| b.transactions[i].l1BlockNumber = block.transactions[i].l1BlockNumber | ||
| if (b.transactions[i].l1BlockNumber != null) { | ||
| b.transactions[i].l1BlockNumber = parseInt(b.transactions[i].l1BlockNumber, 16) |
Contributor
There was a problem hiding this comment.
This should be set to the l1BlockNumber even for sequencer transactions 😭
snario
pushed a commit
that referenced
this pull request
Apr 14, 2021
protolambda
added a commit
to protolambda/optimism
that referenced
this pull request
May 1, 2022
bap2pecs
pushed a commit
to babylonlabs-io/optimism
that referenced
this pull request
Jul 31, 2024
…eum-optimism#354) Closes ethereum-optimism#350 This PR implements Merkle tree-based public randomness commitment. This includes - reverting the BIP-32 thing that is vulnerable - introducing storage of Merkle proofs - revising semantics of submitting public randomness and finality signatures Future works that will be done in subsequent PRs: - **DB schema:** instead of storing all proofs (which is O(n log n)), we need to find an efficient way to store Merkle tree and keep it in memory when it's used. - **Optimisation of proof generation/veirfictaion:** we are considering to use pollarding of Merkle tree, i.e., babylon side remembers the top X levels in the Merkle tree and the Merkle proof will become hashses in the levels lower than X. see https://github.com/wealdtech/go-merkletree/blob/master/pollard.go - **Better vector commitment schemes:** Merkle tree has other variants that have better performance in scenarios with millions of leaves. Ethereum community has stuff like Verkle tree and SSZ
Ayiga
referenced
this pull request
in EspressoSystems/optimism-espresso-integration
Mar 19, 2025
Don't use *big.Int as map key for beacon genesis. big.Ints are not directly comparable in go since they contain a slice, meaning they cannot be used as a map key, using a pointer to a big.Int results in pointer equality being used for map lookups which is not what we wanted. Before this change all lookups for genesis start time would have resulted in 0.
agusduha
added a commit
that referenced
this pull request
Mar 27, 2025
* fix: go linter * fix: integration tests * fix: intent test * fix: upgrade test * fix: lint
theochap
pushed a commit
that referenced
this pull request
Dec 10, 2025
Removes dynamic dispatch from the host-oriented types in `kona-preimage`, in favor of a more flexible and readable alternative. lint
theochap
pushed a commit
that referenced
this pull request
Jan 15, 2026
<!-- Thank you for your Pull Request. Please provide a description above and review the requirements below. Bug fixes and new features should include tests. Contributors guide: https://github.com/alloy-rs/core/blob/main/CONTRIBUTING.md The contributors guide includes instructions for running rustfmt and building the documentation. --> <!-- ** Please select "Allow edits from maintainers" in the PR Options ** --> ## Motivation Closes alloy-rs/op-alloy#353 ## Solution Update target `wasm32-wasi` to `wasm32-wasip1` for ci ## PR Checklist - [ ] Added Tests - [ ] Added Documentation - [ ] Breaking changes
emhane
pushed a commit
that referenced
this pull request
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update deps explicitly, return
l1BlockNumberas a JS number instead of hex stringMetadata
Fixes
Contributing Agreement