Skip to content

Update ethers block formatter & fix inconsistency#350

Merged
tynes merged 4 commits intomasterfrom
fix/block_format
Nov 4, 2020
Merged

Update ethers block formatter & fix inconsistency#350
tynes merged 4 commits intomasterfrom
fix/block_format

Conversation

@karlfloersch
Copy link
Copy Markdown
Contributor

Description

Fixes the provider to return needed metadata & add support for some small api inconsistencies.

Contributing Agreement

@karlfloersch karlfloersch requested a review from tynes November 4, 2020 05:05
Copy link
Copy Markdown
Collaborator

@ben-chain ben-chain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment about a deprecated type but LGTM!

export const txTypePlainText = {
0: TxType.EIP155,
1: TxType.EthSign,
2: TxType.createEOA,
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noting this type is getting deprecated!

@tynes tynes merged commit e0f1473 into master Nov 4, 2020
@tynes tynes deleted the fix/block_format branch November 4, 2020 17:51
snario pushed a commit that referenced this pull request Apr 14, 2021
* Another stab at a good hardhat-deploy

* Testing etherscan verifications

* Fix linting

* remove artifacts

* keep old deploy script

* remove old hardhat-typechain dependency

* remove unused import

* remove kovan config

* Tweak deployment a bit

* Clean up defaults

* rename hardhat => hh

* Use mock bond manager

* Make deploy a bit more robust

* I committed my private key again. There goes my goerli eth

* and my infura api key too

* Fix lint errors

* Use strict ordering

* refactor: use helper for easy AddressManager deployments (#350)

* Clean up georgios pr

* use dotenv to manage deployer keys

* Update src/hardhat-deploy-ethers.ts

Co-authored-by: Georgios Konstantopoulos <me@gakonst.com>

* Stricter checking on address set

* add argument for sequencer address

* minor tweaks to console.log comments

* move predeploy addresses into their own file

* add small comment for clarity

* update deploy script

* fix incorrect env var in deploy script

* adding deploy.js shim to get ci to work

* simplify deployment environment vars

* temporary tweaks to get a ci run to pass

* print out deploy artifacts

* fix artifact log output format

* fix contract names in artifact log output

* add eth gateway to deploy

* add OVM_Proposer to address manager

* add some comments for clarity

* remove bytecode hash from compiler settings

* minor tweaks in response to review

* transfer address manager ownership after deploy

* explicitly attach deployer to address manager

Co-authored-by: Georgios Konstantopoulos <me@gakonst.com>
bap2pecs pushed a commit to babylonlabs-io/optimism that referenced this pull request Jul 31, 2024
…eum-optimism#354)

Closes ethereum-optimism#350 

This PR implements Merkle tree-based public randomness commitment. This
includes

- reverting the BIP-32 thing that is vulnerable
- introducing storage of Merkle proofs 
- revising semantics of submitting public randomness and finality
signatures

Future works that will be done in subsequent PRs:

- **DB schema:** instead of storing all proofs (which is O(n log n)), we
need to find an efficient way to store Merkle tree and keep it in memory
when it's used.
- **Optimisation of proof generation/veirfictaion:** we are considering
to use pollarding of Merkle tree, i.e., babylon side remembers the top X
levels in the Merkle tree and the Merkle proof will become hashses in
the levels lower than X. see
https://github.com/wealdtech/go-merkletree/blob/master/pollard.go
- **Better vector commitment schemes:** Merkle tree has other variants
that have better performance in scenarios with millions of leaves.
Ethereum community has stuff like Verkle tree and SSZ
github-merge-queue bot pushed a commit that referenced this pull request Apr 8, 2025
* feat: access list and executing message event tests (#350)

* fix: semgrep (#356)

---------

Co-authored-by: Disco <131301107+0xDiscotech@users.noreply.github.com>
iquidus pushed a commit to Layr-Labs/optimism that referenced this pull request Jul 24, 2025
* feat: access list and executing message event tests (ethereum-optimism#350)

* fix: semgrep (ethereum-optimism#356)

---------

Co-authored-by: Disco <131301107+0xDiscotech@users.noreply.github.com>
theochap pushed a commit that referenced this pull request Dec 10, 2025
## Overview

Adds benchmarks for the large block tests in the `kona-executor` crate.
theochap pushed a commit that referenced this pull request Jan 15, 2026
emhane pushed a commit that referenced this pull request Feb 3, 2026
Closes #349

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants