Update ethers block formatter & fix inconsistency#350
Merged
Conversation
tynes
reviewed
Nov 4, 2020
ben-chain
approved these changes
Nov 4, 2020
Collaborator
ben-chain
left a comment
There was a problem hiding this comment.
Small comment about a deprecated type but LGTM!
| export const txTypePlainText = { | ||
| 0: TxType.EIP155, | ||
| 1: TxType.EthSign, | ||
| 2: TxType.createEOA, |
Collaborator
There was a problem hiding this comment.
Just noting this type is getting deprecated!
snario
pushed a commit
that referenced
this pull request
Apr 14, 2021
* Another stab at a good hardhat-deploy * Testing etherscan verifications * Fix linting * remove artifacts * keep old deploy script * remove old hardhat-typechain dependency * remove unused import * remove kovan config * Tweak deployment a bit * Clean up defaults * rename hardhat => hh * Use mock bond manager * Make deploy a bit more robust * I committed my private key again. There goes my goerli eth * and my infura api key too * Fix lint errors * Use strict ordering * refactor: use helper for easy AddressManager deployments (#350) * Clean up georgios pr * use dotenv to manage deployer keys * Update src/hardhat-deploy-ethers.ts Co-authored-by: Georgios Konstantopoulos <me@gakonst.com> * Stricter checking on address set * add argument for sequencer address * minor tweaks to console.log comments * move predeploy addresses into their own file * add small comment for clarity * update deploy script * fix incorrect env var in deploy script * adding deploy.js shim to get ci to work * simplify deployment environment vars * temporary tweaks to get a ci run to pass * print out deploy artifacts * fix artifact log output format * fix contract names in artifact log output * add eth gateway to deploy * add OVM_Proposer to address manager * add some comments for clarity * remove bytecode hash from compiler settings * minor tweaks in response to review * transfer address manager ownership after deploy * explicitly attach deployer to address manager Co-authored-by: Georgios Konstantopoulos <me@gakonst.com>
bap2pecs
pushed a commit
to babylonlabs-io/optimism
that referenced
this pull request
Jul 31, 2024
…eum-optimism#354) Closes ethereum-optimism#350 This PR implements Merkle tree-based public randomness commitment. This includes - reverting the BIP-32 thing that is vulnerable - introducing storage of Merkle proofs - revising semantics of submitting public randomness and finality signatures Future works that will be done in subsequent PRs: - **DB schema:** instead of storing all proofs (which is O(n log n)), we need to find an efficient way to store Merkle tree and keep it in memory when it's used. - **Optimisation of proof generation/veirfictaion:** we are considering to use pollarding of Merkle tree, i.e., babylon side remembers the top X levels in the Merkle tree and the Merkle proof will become hashses in the levels lower than X. see https://github.com/wealdtech/go-merkletree/blob/master/pollard.go - **Better vector commitment schemes:** Merkle tree has other variants that have better performance in scenarios with millions of leaves. Ethereum community has stuff like Verkle tree and SSZ
agusduha
pushed a commit
that referenced
this pull request
Apr 2, 2025
iquidus
pushed a commit
to Layr-Labs/optimism
that referenced
this pull request
Jul 24, 2025
* feat: access list and executing message event tests (ethereum-optimism#350) * fix: semgrep (ethereum-optimism#356) --------- Co-authored-by: Disco <131301107+0xDiscotech@users.noreply.github.com>
theochap
pushed a commit
that referenced
this pull request
Dec 10, 2025
## Overview Adds benchmarks for the large block tests in the `kona-executor` crate.
theochap
pushed a commit
that referenced
this pull request
Jan 15, 2026
emhane
pushed a commit
that referenced
this pull request
Feb 3, 2026
Closes #349 --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the provider to return needed metadata & add support for some small api inconsistencies.
Contributing Agreement