Skip to content

ops: Enabled Optimism fee config#2804

Closed
trianglesphere wants to merge 2 commits intodevelopfrom
jg/l1_fee_config_devnet
Closed

ops: Enabled Optimism fee config#2804
trianglesphere wants to merge 2 commits intodevelopfrom
jg/l1_fee_config_devnet

Conversation

@trianglesphere
Copy link
Copy Markdown
Contributor

@trianglesphere trianglesphere commented Jun 16, 2022 •
edited
Loading

Description
Enable L2 Fees to be properly collected and paid out in the devnet.

The baseFeeRecipient is as follows:

  • HD Path: m/44'/60'/0'/0/10
  • Address: 0xBcd4042DE499D14e55001CcbB24a551F3b954096

The l1FeeRecipient is as follows:

  • HD Path: m/44'/60'/0'/0/11
  • Address: 0x71bE63f3384f5fb98995898A86B02Fb2426c5788

Testing

Confirmed that the baseFee is properly sent to the baseFeeRecipient in the devnet.
The coinbase on L2 is already funded so it is hard to confirm that the tip amount, but the coinbase balance did increase after the block with the transaction in it.
On the devnet it appears that the L1Cost contract is not initialized and thus not sending anything to the l1FeeRecipient

@trianglesphere trianglesphere requested a review from mslipper June 16, 2022 17:55
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jun 16, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 27bec6f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@trianglesphere
Copy link
Copy Markdown
Contributor Author

trianglesphere commented Jun 16, 2022

Note: It is important to not merge this PR until the L2 Geth clientes are all updated.

@trianglesphere trianglesphere marked this pull request as ready for review June 16, 2022 19:07
@trianglesphere trianglesphere requested a review from tuxcanfly June 16, 2022 19:08
@trianglesphere
Copy link
Copy Markdown
Contributor Author

trianglesphere commented Jun 16, 2022

Damn, this is gonna conflict with mark's PR which generates this from scratch every time

@trianglesphere trianglesphere mentioned this pull request Jun 16, 2022
Merged
@tuxcanfly
Copy link
Copy Markdown
Contributor

tuxcanfly commented Jun 16, 2022

Should updating values in GasPriceOracle be a part of devnet script? That will fix the issue with l1FeeRecipient

@tynes
Copy link
Copy Markdown
Contributor

tynes commented Jun 17, 2022

If we stayed.setbalance it doesn't execute evm so the l1cost recipient should receive the eth?

@trianglesphere
Copy link
Copy Markdown
Contributor Author

trianglesphere commented Jun 22, 2022

closing in favor of #2781

@trianglesphere trianglesphere deleted the jg/l1_fee_config_devnet branch July 7, 2022 20:16
theochap added a commit that referenced this pull request Dec 10, 2025
@theochap
feat(node/test): add l2 reorg tests (#2804)
1109404 
## Description

Add a couple of l2 reorg tests with an appropriate network
configuration.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@optimisticben optimisticben Awaiting requested review from optimisticben

@tuxcanfly tuxcanfly Awaiting requested review from tuxcanfly

1 more reviewer

@mslipper mslipper mslipper approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@trianglesphere @tuxcanfly @tynes @mslipper @maurelian