Skip to content

contracts-bedrock: genesis builder#2781

Merged
mergify[bot] merged 12 commits intodevelopfrom
feat/genesis-builder
Jun 22, 2022
Merged

contracts-bedrock: genesis builder#2781
mergify[bot] merged 12 commits intodevelopfrom
feat/genesis-builder

Conversation

@tynes
Copy link
Copy Markdown
Contributor

@tynes tynes commented Jun 14, 2022 •
edited
Loading

Description
Hardhat tasks are added for building config files for the devnet.

To run the script, use the command:

$ npx hardhat genesis-l1
$ npx hardhat genesis-l2
$ npx hardhat rollup-config

The devnet-up.sh script is refactored to use these hardhat tasks instead of manually building JSON. This should make it much easier to do deployments in the future.

Note that due to the way that hardhat manages artifacts, running it without a network (defaults to in memory network) is not guaranteed to work. Pass the flag --network devnetL1 when an L1 node is running. The easiest way to do so is anvil --chain-id 900

The predeploys are placed behind proxies. All of the implementations of the predeploys are set at 0xc0d3...x addresses.
The deployment scripts now deploy the L1 contracts behind proxies. They are not guaranteed to work on upgrading an existing network, but they can be used to deploy a new network.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jun 14, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 29893b5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@eth-optimism/contracts-bedrock Patch
@eth-optimism/core-utils Minor
@eth-optimism/common-ts Patch
@eth-optimism/contracts-governance Patch
@eth-optimism/contracts Patch
@eth-optimism/data-transport-layer Patch
@eth-optimism/drippie-mon Patch
@eth-optimism/fault-detector Patch
@eth-optimism/message-relayer Patch
@eth-optimism/replica-healthcheck Patch
@eth-optimism/sdk Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mergify mergify bot requested a review from mslipper June 14, 2022 21:57
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 14, 2022

This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?

@mergify mergify bot requested a review from tuxcanfly June 14, 2022 21:57
@tynes
Copy link
Copy Markdown
Contributor Author

tynes commented Jun 14, 2022

This PR places a proxy at every possible predeploy addr with the admin set to a configurable value and the implementations of existing predeploys set at in the 0xc0d3.. namespace

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 15, 2022

Hey @tynes! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Jun 15, 2022
@tynes tynes force-pushed the feat/genesis-builder branch from b99e878 to 637369f Compare June 15, 2022 22:19
@mergify mergify bot removed the conflict label Jun 15, 2022
@tynes tynes force-pushed the feat/genesis-builder branch from 9d64450 to 0c7a19b Compare June 15, 2022 22:26
@tynes tynes changed the title wip: genesis builder contracts-bedrock: genesis builder Jun 15, 2022
@tynes tynes marked this pull request as ready for review June 15, 2022 22:31
tynes
tynes commented Jun 15, 2022
View reviewed changes
mslipper
mslipper reviewed Jun 15, 2022
View reviewed changes
tynes
tynes commented Jun 15, 2022
View reviewed changes
tynes
tynes commented Jun 15, 2022
View reviewed changes
tynes
tynes commented Jun 15, 2022
View reviewed changes
@trianglesphere
Copy link
Copy Markdown
Contributor

trianglesphere commented Jun 16, 2022

This PR needs to figure out how to integrate the new fee config: #2804

trianglesphere
trianglesphere reviewed Jun 17, 2022
View reviewed changes
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 21, 2022

Hey @tynes! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Jun 21, 2022
@tynes tynes force-pushed the feat/genesis-builder branch from b5ab7c5 to 8cca3df Compare June 21, 2022 21:57
@mergify mergify bot removed the conflict label Jun 21, 2022
@github-actions github-actions bot added the A-pkg-core-utils Area: packages/core-utils label Jun 21, 2022
tynes
tynes commented Jun 21, 2022
View reviewed changes
@trianglesphere trianglesphere mentioned this pull request Jun 22, 2022
Closed
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 22, 2022

Hey @tynes! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Jun 22, 2022
@tynes tynes force-pushed the feat/genesis-builder branch from b04c055 to 4c9b86d Compare June 22, 2022 16:43
@mergify mergify bot removed the conflict label Jun 22, 2022
@tynes tynes force-pushed the feat/genesis-builder branch from 329103f to 369e490 Compare June 22, 2022 19:29
tynes
tynes commented Jun 22, 2022
View reviewed changes
trianglesphere
trianglesphere approved these changes Jun 22, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@trianglesphere trianglesphere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.
Do you know when the new version of foundry will be coming out / when we need to remove that comment?

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 22, 2022

Hey @tynes! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Jun 22, 2022
@mergify mergify bot removed the conflict label Jun 22, 2022
@tynes
Copy link
Copy Markdown
Contributor Author

tynes commented Jun 22, 2022

lgtm. Do you know when the new version of foundry will be coming out / when we need to remove that comment?

Currently blocked by this: foundry-rs/hardhat#61
Hoping to trigger a release asap once this is resolved, git issues with changesets blocking currently

@mslipper
Copy link
Copy Markdown
Contributor

mslipper commented Jun 22, 2022

@Mergifyio refresh

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 22, 2022

refresh

✅ Pull request refreshed

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 22, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify mergify bot merged commit 700dcbb into develop Jun 22, 2022
@mergify mergify bot deleted the feat/genesis-builder branch June 22, 2022 23:25
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 22, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot removed the on-merge-train label Jun 22, 2022
theochap pushed a commit that referenced this pull request Dec 10, 2025
@sadiq1971
fix(supervisor): refactored error logging (#2781)
cdd4c44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tuxcanfly tuxcanfly Awaiting requested review from tuxcanfly

2 more reviewers

@mslipper mslipper mslipper approved these changes

@trianglesphere trianglesphere trianglesphere approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-pkg-core-utils Area: packages/core-utils

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tynes @trianglesphere @mslipper