Skip to content

feat(contracts): add isOutputFinalized function#2598

Merged
mergify[bot] merged 7 commits intodevelopfrom
feat/is-output-finalized
Jun 27, 2022
Merged

feat(contracts): add isOutputFinalized function#2598
mergify[bot] merged 7 commits intodevelopfrom
feat/is-output-finalized

Conversation

@tynes
Copy link
Copy Markdown
Contributor

@tynes tynes commented May 23, 2022

Description

An external function that can be used for apps to
check to see if a particular output is finalized.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented May 23, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 951deff

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@eth-optimism/contracts-bedrock Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tynes tynes changed the title feat(contracts): add isOutputFinalize function feat(contracts): add isOutputFinalized function May 23, 2022
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented May 23, 2022

This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?

smartcontracts
smartcontracts reviewed May 28, 2022
View reviewed changes
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 2, 2022

Hey @tynes! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Jun 2, 2022
smartcontracts
smartcontracts approved these changes Jun 9, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@smartcontracts smartcontracts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with optional convos left unresolved, feel free to address or simply mark resolved

@maurelian maurelian mentioned this pull request Jun 9, 2022
Merged
2 tasks
@maurelian maurelian force-pushed the feat/is-output-finalized branch from 1e76993 to c7293a0 Compare June 17, 2022 18:56
@mergify mergify bot removed the conflict label Jun 17, 2022
@maurelian
Copy link
Copy Markdown
Contributor

maurelian commented Jun 17, 2022

I rebased this to fix the conflicts and make it compatible with the recent oracle changes in #2707.
Since I'm one of the approvers, I think we should get another approval from @tynes before merging, so I applied the mergify-ignore label.

maurelian
maurelian reviewed Jun 17, 2022
View reviewed changes
@maurelian maurelian self-requested a review June 17, 2022 19:45
@maurelian
Copy link
Copy Markdown
Contributor

maurelian commented Jun 17, 2022

I wrote a little poc for looking up blocknumbers that aren't written to the oracle:
develop...maurelian:feat/is-output-finalized#diff-db27494cd2

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 22, 2022

Hey @tynes! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Jun 22, 2022
tynes added 3 commits June 23, 2022 13:48
@tynes
feat(contracts): add isOutputFinalize function
577175c 
An `external` function that can be used for apps to
check to see if a particular output is finalized.
@tynes
bindings: regenerate
7adb4cb
@tynes
contracts: update gas-snapshot
1d7b9b3
@tynes tynes force-pushed the feat/is-output-finalized branch from c7293a0 to 1d7b9b3 Compare June 23, 2022 20:52
@mergify mergify bot removed the conflict label Jun 23, 2022
@tynes
Copy link
Copy Markdown
Contributor Author

tynes commented Jun 23, 2022

I wrote a little poc for looking up blocknumbers that aren't written to the oracle: develop...maurelian:feat/is-output-finalized#diff-db27494cd2

I pulled in this commit, thank you!

@tynes tynes force-pushed the feat/is-output-finalized branch from 28823d5 to d24757a Compare June 23, 2022 21:06
@tynes
Copy link
Copy Markdown
Contributor Author

tynes commented Jun 23, 2022

@maurelian This is ready for review again

maurelian
maurelian reviewed Jun 24, 2022
View reviewed changes
@maurelian
Copy link
Copy Markdown
Contributor

maurelian commented Jun 24, 2022

Fix typo and lint and should be good.

@tynes @maurelian
contracts-bedrock: update isOutputFinalized
9ae938a 
Co-authored-by: Maurelian <maurelian@protonmail.ch>
@tynes tynes force-pushed the feat/is-output-finalized branch from d24757a to 9ae938a Compare June 27, 2022 16:28
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 27, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 27, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot merged commit 5bb6f2c into develop Jun 27, 2022
@mergify mergify bot deleted the feat/is-output-finalized branch June 27, 2022 17:29
@mergify mergify bot removed the on-merge-train label Jun 27, 2022
theochap pushed a commit that referenced this pull request Dec 10, 2025
@clabby
feat!(bin/node): Remove --l2.provider flag (#2598)
3fca5a3 
## Overview

Removes the `--l2.provider` flag from the `kona-node` in favor of
proxying L2 RPC requests through the engine API.

### TODO

This change is breaking to the CLI interface, and will require an update
to:
- [x] The `optimism-package`
- [ ] The helm charts in OP Labs' infrastructure (not blocking)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maurelian maurelian maurelian approved these changes

@smartcontracts smartcontracts smartcontracts approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tynes @maurelian @smartcontracts