Skip to content

integration-tests: Fix merge issue#2250

Merged
mslipper merged 1 commit intoethereum-optimism:developfrom
mslipper:bugfix/itests
Mar 3, 2022
Merged

integration-tests: Fix merge issue#2250
mslipper merged 1 commit intoethereum-optimism:developfrom
mslipper:bugfix/itests

Conversation

@mslipper
Copy link
Copy Markdown
Contributor

@mslipper mslipper commented Mar 3, 2022

PR #2199 introduced removed ctc from env, so the itests for batch serialization need to be updated.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 3, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: e301661

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the A-integration Area: integration tests label Mar 3, 2022
@tuxcanfly
Copy link
Copy Markdown
Contributor

tuxcanfly commented Mar 3, 2022

Verified that compile issue:

An unexpected error occurred:

test/z-batch-serialization.spec.ts:18:28 - error TS2339: Property 'ctc' does not exist on type 'OptimismEnv'.

18     const logs = await env.ctc.queryFilter(
                              ~~~
test/z-batch-serialization.spec.ts:19:11 - error TS2339: Property 'ctc' does not exist on type 'OptimismEnv'.

19       env.ctc.filters.TransactionBatchAppended(),
             ~~~

error Command failed with exit code 1.

was fixed with the changes in the PR.

tuxcanfly
tuxcanfly approved these changes Mar 3, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@tuxcanfly tuxcanfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

@mslipper mslipper merged commit aa726e8 into ethereum-optimism:develop Mar 3, 2022
theochap pushed a commit that referenced this pull request Dec 10, 2025
@dhyaniarun1993
fix(supervisor/core): consistency check (#2250)
63801f2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tynes tynes tynes approved these changes

+1 more reviewer

@tuxcanfly tuxcanfly tuxcanfly approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-integration Area: integration tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mslipper @tuxcanfly @tynes