Remove unnecessary contract references in integration-tests#2199
Remove unnecessary contract references in integration-tests#2199mslipper merged 2 commits intoethereum-optimism:developfrom tonykogias:remove-contract-references-in-integration-tests
Conversation
🦋 Changeset detectedLatest commit: a4198a4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@tonykogias what a beast, nice work! |
Codecov Report
@@ Coverage Diff @@
## develop #2199 +/- ##
===========================================
+ Coverage 73.04% 82.54% +9.49%
===========================================
Files 86 60 -26
Lines 2846 1914 -932
Branches 486 282 -204
===========================================
- Hits 2079 1580 -499
+ Misses 767 334 -433
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
integration-tests/test/shared/env.ts
Outdated
| l2SignerOrProvider: l2Wallet, | ||
| l1ChainId: network.chainId, | ||
| contracts: { | ||
| l1: { |
There was a problem hiding this comment.
You can actually leave this out, the SDK will pick the contract addresses automatically based on the chain ID.
There was a problem hiding this comment.
cc @mslipper I just need the contract addresses for nightly so that it will work correctly in the integration tests.
There was a problem hiding this comment.
@tonykogias let's remove the entire contracts object here, should be pulled in automatically
There was a problem hiding this comment.
cc @mslipper I just need the contract addresses for nightly so that it will work correctly in the integration tests.
We should be able to support addresses that aren't hardcoded - the point of nightly is that it can be blown away and fully redeployed at any moment
smartcontracts
left a comment
There was a problem hiding this comment.
Just needs a changeset and this will be good to go. Great work.
|
Approved + merging since it has the changeset now. |
Description
Remove unnecessary contract references in integration-tests
Metadata