go/batch-submitter: Add releases for go BSS#2060
go/batch-submitter: Add releases for go BSS#2060mslipper merged 3 commits intoethereum-optimism:developfrom
Conversation
🦋 Changeset detectedLatest commit: 7612d91 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## develop #2060 +/- ##
========================================
Coverage 74.73% 74.73%
========================================
Files 80 80
Lines 2561 2561
Branches 403 403
========================================
Hits 1914 1914
Misses 647 647
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
.github/workflows/release.yml
Outdated
There was a problem hiding this comment.
This file has typos in it, its referring to canary-publish which will not exist, it should be needs.release.outputs.batch-submitter-service
tynes
left a comment
There was a problem hiding this comment.
A very common error is found in this PR - the same bug is introduced 1 in 3 times a service is added to the build pipeline. This indicates to me that this should be refactored eventually to deduplicate some of the config
cfromknecht
left a comment
There was a problem hiding this comment.
LGTM barring mark's comments 👍
648149c to
8986580
Compare
No description provided.