Skip to content

l2geth: use minimal EIP 2929#1568

Merged
tynes merged 1 commit intoexperimentalfrom
l2geth/minimal-eip2929
Oct 14, 2021
Merged

l2geth: use minimal EIP 2929#1568
tynes merged 1 commit intoexperimentalfrom
l2geth/minimal-eip2929

Conversation

@tynes
Copy link
Copy Markdown
Contributor

@tynes tynes commented Oct 13, 2021

Description

Use a minimal version of EIP 2929 for state accessing
opcodes. This does not pull in the access list logic
but instead charges based on cold access assumptions
at all times

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Oct 13, 2021 •
edited
Loading

🦋 Changeset detected

Latest commit: ba65c54

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@eth-optimism/l2geth Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 13, 2021 •
edited
Loading

Codecov Report

Merging #1568 (ba65c54) into experimental (b690575) will decrease coverage by 0.57%.
The diff coverage is 80.00%.

Impacted file tree graph

@@               Coverage Diff                @@
##           experimental    #1568      +/-   ##
================================================
- Coverage         74.20%   73.62%   -0.58%     
================================================
  Files                67       67              
  Lines              2210     2207       -3     
  Branches            321      324       +3     
================================================
- Hits               1640     1625      -15     
- Misses              570      582      +12
Flag Coverage Δ
batch-submitter 61.74% <ø> (ø)
contracts 90.44% <100.00%> (-0.74%) ⬇️
core-utils 55.73% <28.57%> (-0.77%) ⬇️
data-transport-layer 38.23% <ø> (ø)
message-relayer 83.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/core-utils/src/common/hex-strings.ts 86.11% <28.57%> (-13.89%) ⬇️
.../contracts/L1/messaging/L1CrossDomainMessenger.sol 96.77% <100.00%> (ø)
.../contracts/L1/rollup/CanonicalTransactionChain.sol 85.04% <100.00%> (-2.89%) ⬇️
...acts/contracts/L1/rollup/ChainStorageContainer.sol 70.00% <0.00%> (-10.00%) ⬇️
...contracts/contracts/libraries/utils/Lib_Buffer.sol 92.85% <0.00%> (-7.15%) ⬇️
packages/batch-submitter/hardhat.config.ts 100.00% <0.00%> (ø)
...ages/contracts/contracts/L2/predeploys/OVM_ETH.sol 100.00% <0.00%> (ø)
.../contracts/contracts/standards/L2StandardERC20.sol 100.00% <0.00%> (ø)
...ontracts/contracts/L1/verification/BondManager.sol 100.00% <0.00%> (ø)
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92e76f1...ba65c54. Read the comment docs.

smartcontracts
smartcontracts reviewed Oct 13, 2021
View reviewed changes
l2geth/core/vm/eips.go Outdated
Copy link
Copy Markdown
Contributor

@smartcontracts smartcontracts Oct 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From here down it's identical to https://github.com/ethereum/go-ethereum/blob/011fe3eb5e29e246ba14e7c9675c536cf7123305/core/vm/eips.go#L118-L142

Except SELFDESTRUCT: https://github.com/ethereum/go-ethereum/blob/011fe3eb5e29e246ba14e7c9675c536cf7123305/core/vm/eips.go#L144-L147

Why?

Copy link
Copy Markdown
Contributor Author

@tynes tynes Oct 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't port the selfdestruct changes because I was thinking that they would be out of scope for this set of changes. We could port them as well if you are opinionated, it would require bringing this function into the codebase and removing the accesslist based logic
https://github.com/ethereum/go-ethereum/blob/a5669ae292274d3b0a223cda07ebe64f943bded4/core/vm/operations_acl.go#L229

Copy link
Copy Markdown
Contributor Author

@tynes tynes Oct 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ended up porting the self destruct change as well

l2geth/core/vm/eips.go Outdated
Copy link
Copy Markdown
Contributor

@smartcontracts smartcontracts Oct 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Geth, this logic is included in vm/operations_acl.go. Might as well create a file with the same name and move this logic there to simplify the future porting process.

Copy link
Copy Markdown
Contributor Author

@tynes tynes Oct 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've moved functionality to this file

@tynes tynes force-pushed the l2geth/minimal-eip2929 branch 2 times, most recently from 26b205d to b4a045b Compare October 13, 2021 23:00
karlfloersch
karlfloersch approved these changes Oct 14, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@karlfloersch karlfloersch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tynes
l2geth: use minimal EIP 2929
ba65c54 
Use a minimal version of EIP 2929 for state accessing
opcodes. This does not pull in the access list logic
but instead charges based on cold access assumptions
at all times
@tynes tynes force-pushed the l2geth/minimal-eip2929 branch from b4a045b to ba65c54 Compare October 14, 2021 18:03
@tynes tynes merged commit d0f7994 into experimental Oct 14, 2021
@tynes tynes deleted the l2geth/minimal-eip2929 branch October 14, 2021 18:22
@holgerd77 holgerd77 mentioned this pull request May 23, 2023
Open
theochap pushed a commit that referenced this pull request Dec 10, 2025
@refcell @clabby
feat(p2p): Address Blocking (#2060)
11c0ba2 
### Description

Implements IP Address blocking.

Closes #1566
Closes #1569
Closes #1568

---------

Co-authored-by: clabby <ben@clab.by>
theochap pushed a commit that referenced this pull request Jan 14, 2026
@refcell @clabby
feat(p2p): Address Blocking (op-rs/kona#2060)
e05023e 
### Description

Implements IP Address blocking.

Closes #1566
Closes #1569
Closes #1568

---------

Co-authored-by: clabby <ben@clab.by>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@karlfloersch karlfloersch karlfloersch approved these changes

@smartcontracts smartcontracts smartcontracts approved these changes

Assignees

No one assigned

Labels

A-cannon Area: cannon

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tynes @codecov-commenter @karlfloersch @smartcontracts