Skip to content

feat: remove old verification scripts#1769

Merged
smartcontracts merged 1 commit intodevelopfrom
sc/remove-old-verification
Nov 17, 2021
Merged

feat: remove old verification scripts#1769
smartcontracts merged 1 commit intodevelopfrom
sc/remove-old-verification

Conversation

@smartcontracts
Copy link
Copy Markdown
Contributor

Description
Removes two (very) old scripts that were previously used to verify contract deployments.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Nov 15, 2021

⚠️ No Changeset found

Latest commit: b5798fb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 15, 2021

Codecov Report

Merging #1769 (b5798fb) into develop (42ae8e3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1769   +/-   ##
========================================
  Coverage    71.81%   71.81%           
========================================
  Files           69       69           
  Lines         2303     2303           
  Branches       344      344           
========================================
  Hits          1654     1654           
  Misses         649      649           
Flag Coverage Δ
batch-submitter 61.56% <ø> (ø)
contracts 87.96% <ø> (ø)
core-utils 56.53% <ø> (ø)
data-transport-layer 38.23% <ø> (ø)
message-relayer 70.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42ae8e3...b5798fb. Read the comment docs.

@tynes
Copy link
Copy Markdown
Contributor

tynes commented Nov 15, 2021

@maurelian you have been working on verification scripts recently, do you think that these should be re-adapted and added instead as a hardhat task?

@smartcontracts
Copy link
Copy Markdown
Contributor Author

@maurelian you have been working on verification scripts recently, do you think that these should be re-adapted and added instead as a hardhat task?

We 100% should add verification again in the future

@maurelian
Copy link
Copy Markdown
Contributor

maurelian commented Nov 16, 2021

@tynes @smartcontracts the checks I wrote for the previous regenesis are here: #1753.

If you think they'd be better as tasks, I don't mind converting them to that. LMK what you think over there please. They are tasks already.

Either way, this PR make sense to me.

@smartcontracts smartcontracts force-pushed the sc/remove-old-verification branch from 92cbf9a to b5798fb Compare November 17, 2021 16:20
@smartcontracts smartcontracts merged commit 1bd999b into develop Nov 17, 2021
@smartcontracts smartcontracts deleted the sc/remove-old-verification branch November 17, 2021 16:43
theochap pushed a commit that referenced this pull request Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants