Skip to content

Add checks for proper config values in deployment validation#1753

Merged
maurelian merged 1 commit intodevelopfrom
maurelian/check-moar-things
Dec 8, 2021
Merged

Add checks for proper config values in deployment validation#1753
maurelian merged 1 commit intodevelopfrom
maurelian/check-moar-things

Conversation

@maurelian
Copy link
Copy Markdown
Contributor

@maurelian maurelian commented Nov 12, 2021 •
edited
Loading

This PR contains the most complete version of the deployment validation scripts which were run during the 0.5.0 regenesis.

Since the regenesis I've made quite a few small adjustments to improve the UX, but all the checks present here were also done prior to finalizing the upgrades.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Nov 12, 2021 •
edited
Loading

🦋 Changeset detected

Latest commit: bbd42e0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@eth-optimism/contracts Patch
@eth-optimism/batch-submitter Patch
@eth-optimism/data-transport-layer Patch
@eth-optimism/message-relayer Patch
@eth-optimism/sdk Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 12, 2021 •
edited
Loading

Codecov Report

Merging #1753 (ae42fdb) into develop (b882d8c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1753   +/-   ##
========================================
  Coverage    71.81%   71.81%           
========================================
  Files           69       69           
  Lines         2303     2303           
  Branches       344      344           
========================================
  Hits          1654     1654           
  Misses         649      649
Flag Coverage Δ
batch-submitter 61.56% <ø> (ø)
contracts 87.96% <ø> (ø)
core-utils 56.53% <ø> (ø)
data-transport-layer 38.23% <ø> (ø)
message-relayer 70.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b882d8c...ae42fdb. Read the comment docs.

tynes
tynes reviewed Nov 12, 2021
View reviewed changes
packages/contracts/tasks/validate-chugsplash-dictator.ts Outdated
Copy link
Copy Markdown
Contributor

@tynes tynes Nov 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to delete this line?

Copy link
Copy Markdown
Contributor Author

@maurelian maurelian Nov 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did yes!

@maurelian maurelian force-pushed the maurelian/check-moar-things branch from 76c22e8 to 5c642be Compare November 13, 2021 03:21
@maurelian maurelian requested a review from tynes November 13, 2021 03:22
@maurelian maurelian force-pushed the maurelian/check-moar-things branch from 5c642be to ae42fdb Compare November 13, 2021 03:22
@maurelian maurelian mentioned this pull request Nov 16, 2021
Merged
@maurelian maurelian force-pushed the maurelian/check-moar-things branch 2 times, most recently from 5e2a4b0 to e986dc8 Compare November 18, 2021 16:59
@maurelian maurelian force-pushed the maurelian/check-moar-things branch from 08754c2 to 94a33bd Compare November 26, 2021 19:22
@tynes
Copy link
Copy Markdown
Contributor

tynes commented Nov 29, 2021

Still looking for review on this?

@maurelian maurelian force-pushed the maurelian/check-moar-things branch from 94a33bd to 35e1047 Compare December 1, 2021 00:05
@maurelian
Copy link
Copy Markdown
Contributor Author

maurelian commented Dec 1, 2021

@tynes yes please!

@maurelian
Copy link
Copy Markdown
Contributor Author

maurelian commented Dec 1, 2021

Also nudge to @smartcontracts ^

@maurelian maurelian force-pushed the maurelian/check-moar-things branch from 35e1047 to bbd42e0 Compare December 8, 2021 02:23
@maurelian maurelian merged commit d667bbb into develop Dec 8, 2021
@maurelian maurelian deleted the maurelian/check-moar-things branch December 8, 2021 16:46
theochap pushed a commit that referenced this pull request Dec 10, 2025
@clabby
feat(node): Retry engine capability handshake (#1753)
7ebda17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tynes tynes tynes approved these changes

@smartcontracts smartcontracts smartcontracts approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@maurelian @codecov-commenter @tynes @smartcontracts