Conversation
ben-chain
left a comment
There was a problem hiding this comment.
Woot woot!!! Looks good to me 😁
| try { | ||
| // delete the single appended block | ||
| await l1ToL2TxQueue.dequeueBeforeInclusive(blockIndex) | ||
| } catch (err) { | ||
| // Success we threw an error! | ||
| return | ||
| } | ||
| throw new Error( | ||
| 'Allowed non-canonicalTransactionChain account to dequeue block' |
| try { | ||
| await l1ToL2TxQueue.enqueueBlock(block) | ||
| } catch (err) { | ||
| // Success we threw an error! | ||
| return | ||
| } |
There was a problem hiding this comment.
Note we do have a TestUtils.assertThrowsAsync which replicates this functionality :)
There was a problem hiding this comment.
Would also check the error that is thrown to make sure it is doing the right thing vs failing for some other reason when doing the wrong thing.
| try { | ||
| await l1ToL2TxQueue.enqueueBlock(block) | ||
| } catch (err) { | ||
| // Success we threw an error! | ||
| return | ||
| } |
There was a problem hiding this comment.
Would also check the error that is thrown to make sure it is doing the right thing vs failing for some other reason when doing the wrong thing.
| import { DefaultRollupBlock } from './RLhelper' | ||
|
|
||
| /* Logging */ | ||
| const log = getLogger('l1-to-l2-tx-queue') |
There was a problem hiding this comment.
| const log = getLogger('l1-to-l2-tx-queue') | |
| const log = getLogger('l1-to-l2-tx-queue', true) |
There was a problem hiding this comment.
Oh yes good point, come to think of it I think there is an assertRevertsAsync which accepts an EVM revert message to check!
* fix rlp encoding bug in contract dump * lint
## Overview Fixes the release plz job by using the same versions of `alloy-*` crates in `kona-mpt` as in `kona-derive`
## Overview Removes the `Holocene` variant of the L1 info transaction. The specification of the dynamic EIP-1559 parameters has changed to put this feature in the `PayloadAttributes` instead. ethereum-optimism/specs#404
Description
Implementation of L1ToL2 Transaction Queue. I will eventually separate the RollupList into RollupQueue and RollupStack contracts to clean up this code, but will do so once I implement the rest of the queues/stacks and know what the best way to do that separation is.
Questions
rollup-contractspackage?Fixes
Contributing Agreement