feat(holocene): Simplify `eip1559Params` by clabby · Pull Request #404 · ethereum-optimism/specs

clabby · 2024-10-01T00:57:06Z

Overview

Simplifies the dynamic EIP-1559 params feature of Holocene by including the parameters within the PayloadAttributesV3 and the block Header.

Rationale

Currently, the EIP-1559 parameters are included within the L1Block contract. However, unlike other variables within the L1 info transaction:

The EIP-1559 parameters are unlikely to change frequently enough to warrant being in the L1 info transaction. Most other fields change every L1 block, but even on the most ambitious OP Stack chains (Base), they only expect these values to change once per week.
In the execution engine, all OP Stack EVM implementations currently load the L1 block info from the state database. However, since the EIP-1559 parameters are required at the beginning of the block, we would also need to lift this out of the EVM and into the block executor.
The EIP-1559 params in L1 info makes the function to compute the next block's basefee stateful. That becomes a fairly invasive change, where the pre-block environment fillers now have to have access to the database, L1 block info formation from storage slots logic, etc. In reth, for example, the base fee computation function is within a lower-level config type, without access to the state or transactions. Ultimately we lose database access several layers of abstraction higher up, warranting a refactor to make this change work. In geth, it's similar, but the change is a bit less invasive higher up with only 2 layers to pass the state handle through.

There's precedent for SystemConfig variables that are needed at the beginning of a block, or that don't update frequently, to belong within the PayloadAttributes (The gas_limit). The block builder additionally having access to control the EIP-1559 parameters is constrained by consensus rule, and similarly to the gasLimit, is specified to be referenced from the SystemConfig in the derivation pipeline's payload builder. This change would simplify this feature's implementation within execution clients and save us from needlessly posting the parameters in the L1 info transaction every 2 seconds as such.

Why in the block header?

https://github.com/ethereum-optimism/specs/pull/404/files#diff-b93100978f12975e6b4ee660c7362c71d4f2a416ef7c9f0e76e17ca0062842efR144-R152

clabby · 2024-10-01T00:57:23Z

feat(holocene): Simplify eip1559Params #404 👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @clabby and the rest of your teammates on Graphite

specs/protocol/holocene/exec-engine.md

refcell · 2024-10-01T15:27:38Z

Although I think this is sound, I'm a bit concerned of using the nonce in case we need it down the road for something. Placing these in the L1 info feels more scalable to me and is a more consistent way of introducing modifications, though there is the aforementioned tradeoff that the basefee computation becomes invasive.

specs/protocol/holocene/exec-engine.md

tynes · 2024-10-01T17:43:28Z

We should make sure that there is a getter for EIP1559 params on the SystemConfig so that its legible on chain what the config is. This will help to make standardness checks possible as part of the superchain-registry. This might also be in the spec, I just see the getters removed from the L1Block contract, would be good to double check

specs/protocol/holocene/configurability.md

specs/protocol/holocene/exec-engine.md

## Overview Removes the `Holocene` variant of the L1 info transaction. The specification of the dynamic EIP-1559 parameters has changed to put this feature in the `PayloadAttributes` instead. ethereum-optimism/specs#404

…utes` (#138) ## Overview Adds the `eip1559Params` field to the `OptimismPayloadAttributes, per ethereum-optimism/specs#404

## Overview Removes the `Holocene` variant of the L1 info transaction. The specification of the dynamic EIP-1559 parameters has changed to put this feature in the `PayloadAttributes` instead. ethereum-optimism/specs#404

…utes` (#138) ## Overview Adds the `eip1559Params` field to the `OptimismPayloadAttributes, per ethereum-optimism/specs#404

…p-alloy#137) ## Overview Removes the `Holocene` variant of the L1 info transaction. The specification of the dynamic EIP-1559 parameters has changed to put this feature in the `PayloadAttributes` instead. ethereum-optimism/specs#404

…utes` (alloy-rs/op-alloy#138) ## Overview Adds the `eip1559Params` field to the `OptimismPayloadAttributes, per ethereum-optimism/specs#404

## Overview Removes the `Holocene` variant of the L1 info transaction. The specification of the dynamic EIP-1559 parameters has changed to put this feature in the `PayloadAttributes` instead. ethereum-optimism/specs#404

…utes` (#138) ## Overview Adds the `eip1559Params` field to the `OptimismPayloadAttributes, per ethereum-optimism/specs#404

## Overview Removes the `Holocene` variant of the L1 info transaction. The specification of the dynamic EIP-1559 parameters has changed to put this feature in the `PayloadAttributes` instead. ethereum-optimism/specs#404

…utes` (#138) ## Overview Adds the `eip1559Params` field to the `OptimismPayloadAttributes, per ethereum-optimism/specs#404

clabby requested review from ajsutton, mslipper, protolambda, sebastianst and tynes as code owners October 1, 2024 00:57

clabby force-pushed the cl/rm-l1-info branch 2 times, most recently from 4c10e4c to 6c74c7e Compare October 1, 2024 01:02

clabby marked this pull request as draft October 1, 2024 01:35

clabby closed this Oct 1, 2024

clabby reopened this Oct 1, 2024

clabby force-pushed the cl/rm-l1-info branch 3 times, most recently from a3aea03 to c0f02e4 Compare October 1, 2024 04:50

clabby changed the title ~~chore(holocene): Simplify eip1559Params~~ feat(holocene): Simplify eip1559Params Oct 1, 2024

clabby marked this pull request as ready for review October 1, 2024 05:05

clabby force-pushed the cl/rm-l1-info branch from ecf4af6 to 12ab6e5 Compare October 1, 2024 05:28

refcell reviewed Oct 1, 2024

View reviewed changes

specs/protocol/holocene/exec-engine.md Outdated Show resolved Hide resolved

refcell approved these changes Oct 1, 2024

View reviewed changes

roberto-bayardo reviewed Oct 1, 2024

View reviewed changes

specs/protocol/holocene/exec-engine.md Outdated Show resolved Hide resolved

This was referenced Oct 1, 2024

[HOLOCENE] L1BlockInfoTx::Holocene derivation op-rs/kona#594

Closed

[HOLOCENE] New SystemConfig fields op-rs/kona#595

Closed

clabby force-pushed the cl/rm-l1-info branch from 33f9f02 to 2775e96 Compare October 1, 2024 17:12

clabby added 6 commits October 1, 2024 13:18

chore(holocene): Simplify eip1559Params

db4fa79

lint

16b296e

add section on header extension

5ac140b

toc

0bf000a

change attrs validity rules

41bdd75

fork activation rule

4f22ce4

clabby added 2 commits October 1, 2024 13:18

toc

9db74aa

change from QUANTITY -> DATA

2d9326e

clabby force-pushed the cl/rm-l1-info branch from 2775e96 to 2d9326e Compare October 1, 2024 17:18

update types

f52e8de

clabby force-pushed the cl/rm-l1-info branch from 1da7ced to f52e8de Compare October 1, 2024 17:20

roberto-bayardo approved these changes Oct 1, 2024

View reviewed changes

sebastianst approved these changes Oct 1, 2024

View reviewed changes

review

85d3583

clabby force-pushed the cl/rm-l1-info branch from 5d0051e to 85d3583 Compare October 1, 2024 18:42

toc

19542ce

This was referenced Oct 1, 2024

chore(protocol): Remove L1BlockInfoTx::Holocene variant alloy-rs/op-alloy#137

Merged

feat(rpc-types-engine): EIP-1559 parameters in OptimismPayloadAttributes alloy-rs/op-alloy#138

Merged

tynes approved these changes Oct 1, 2024

View reviewed changes

tynes merged commit fb1fb8e into main Oct 1, 2024

tynes deleted the cl/rm-l1-info branch October 1, 2024 20:03

Inphi mentioned this pull request Oct 1, 2024

Revert "Holocene extensions to L1Block.sol (#12096)" ethereum-optimism/optimism#12236

Merged

refcell pushed a commit to base/base that referenced this pull request Feb 18, 2026

feat(rpc-types-engine): EIP-1559 parameters in `OptimismPayloadAttrib…

0a582c1

…utes` (#138) ## Overview Adds the `eip1559Params` field to the `OptimismPayloadAttributes, per ethereum-optimism/specs#404

refcell pushed a commit to base/base that referenced this pull request Feb 18, 2026

feat(rpc-types-engine): EIP-1559 parameters in `OptimismPayloadAttrib…

10fd1ac

…utes` (#138) ## Overview Adds the `eip1559Params` field to the `OptimismPayloadAttributes, per ethereum-optimism/specs#404

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(holocene): Simplify `eip1559Params`#404

feat(holocene): Simplify `eip1559Params`#404
tynes merged 11 commits intomainfrom
cl/rm-l1-info

clabby commented Oct 1, 2024 •

edited

Loading

Uh oh!

clabby commented Oct 1, 2024

Uh oh!

Uh oh!

refcell commented Oct 1, 2024

Uh oh!

Uh oh!

tynes commented Oct 1, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

clabby commented Oct 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Overview

Rationale

Why in the block header?

Uh oh!

clabby commented Oct 1, 2024

Uh oh!

Uh oh!

refcell commented Oct 1, 2024

Uh oh!

Uh oh!

tynes commented Oct 1, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

clabby commented Oct 1, 2024 •

edited

Loading