feat: liquidity migration#11479
Merged
tynes merged 14 commits intoethereum-optimism:developfrom Aug 21, 2024
Merged
Conversation
* test: add L2 standard bridge interop unit tests * fix: add tests natspec * fix: unit tests fixes * fix: super to legacy tests failing * fix: mock and expect mint and burn
* test: add L2 standard bridge interop unit tests * fix: add tests natspec * fix: add generic factory interface
* test: add L2 standard bridge interop unit tests * fix: add tests natspec * fix: add generic factory interface * feat: modify OptimismMintableERC20Factory for convert * fix: use only a public function for create3 * feat: rollback interop factory, modify legacy one * fix: delete local token return variable
Contributor
|
@agusduha Looks like ci is failing due to the snapshots being out of date. You should be able to run |
Contributor
Author
|
@tynes Snapshots fixed! |
tynes
reviewed
Aug 21, 2024
packages/contracts-bedrock/test/L2/L2StandardBridgeInterop.t.sol
Outdated
Show resolved
Hide resolved
tynes
reviewed
Aug 21, 2024
packages/contracts-bedrock/test/L2/L2StandardBridgeInterop.t.sol
Outdated
Show resolved
Hide resolved
tynes
approved these changes
Aug 21, 2024
Contributor
|
Nice code, very clean |
samlaf
pushed a commit
to samlaf/optimism
that referenced
this pull request
Nov 10, 2024
* feat: add L2 standrad bridge interop contract * test: add L2 standard bridge interop unit tests (ethereum-optimism#13) * test: add L2 standard bridge interop unit tests * fix: add tests natspec * fix: unit tests fixes * fix: super to legacy tests failing * fix: mock and expect mint and burn * fix: add generic factory interface (ethereum-optimism#14) * test: add L2 standard bridge interop unit tests * fix: add tests natspec * fix: add generic factory interface * feat: modify OptimismMintableERC20Factory for convert (ethereum-optimism#17) * test: add L2 standard bridge interop unit tests * fix: add tests natspec * fix: add generic factory interface * feat: modify OptimismMintableERC20Factory for convert * fix: use only a public function for create3 * feat: rollback interop factory, modify legacy one * fix: delete local token return variable * fix: PR fixes * test: fix address assuming * test: fix view warning * fix: snapshots * test: small fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Liquidity Migration Specs will cover the required modifications to allowed converting between legacy and
SuperchainERC20tokens using theL2StandardBridge.Specs: ethereum-optimism/specs#294
Tests
Added
L2StandardBridgeInterop.t.solUpdated
OptimismMintableERC20Factory.t.solAdditional context
TODOs:
OptimismSuperchainERC20FactoryMintableAndBurnableused inL2StandardBridgeInterop.solMetadata