Skip to content

fix: add generic factory interface#14

Merged
agusduha merged 4 commits intosc/liquidity-migrationfrom
fix/add-generic-factory-interface
Aug 9, 2024
Merged

fix: add generic factory interface#14
agusduha merged 4 commits intosc/liquidity-migrationfrom
fix/add-generic-factory-interface

Conversation

@agusduha
Copy link
Copy Markdown
Member

@agusduha agusduha commented Aug 7, 2024

Closes OPT-193

Fixing #10 (comment)

@agusduha agusduha requested review from 0xDiscotech and 0xng August 7, 2024 13:56
@agusduha agusduha self-assigned this Aug 7, 2024
@linear
Copy link
Copy Markdown

linear bot commented Aug 7, 2024

@0xParti
Copy link
Copy Markdown

0xParti commented Aug 7, 2024

clean!

Comment on lines +10 to +11
/// @return _remoteToken The address of the remote token if it is deployed or `address(0)` if not.
function deployments(address _token) external view returns (address _remoteToken);
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On their guidelines, they say they use suffixed returned args (remoteToken_).
Even though I don't like that, should we follow that standard for his new contracts as well?
Or the new contracts developed are not following that particular way?

Base automatically changed from test/standard-bridge-interop-tests to sc/liquidity-migration August 8, 2024 20:23
@agusduha agusduha merged commit 593efad into sc/liquidity-migration Aug 9, 2024
@agusduha agusduha deleted the fix/add-generic-factory-interface branch August 9, 2024 17:04
agusduha added a commit that referenced this pull request Aug 22, 2024
* feat: add L2 standrad bridge interop contract

* test: add L2 standard bridge interop unit tests (#13)

* test: add L2 standard bridge interop unit tests

* fix: add tests natspec

* fix: unit tests fixes

* fix: super to legacy tests failing

* fix: mock and expect mint and burn

* fix: add generic factory interface (#14)

* test: add L2 standard bridge interop unit tests

* fix: add tests natspec

* fix: add generic factory interface

* feat: modify OptimismMintableERC20Factory for convert (#17)

* test: add L2 standard bridge interop unit tests

* fix: add tests natspec

* fix: add generic factory interface

* feat: modify OptimismMintableERC20Factory for convert

* fix: use only a public function for create3

* feat: rollback interop factory, modify legacy one

* fix: delete local token return variable

* fix: PR fixes

* test: fix address assuming

* test: fix view warning

* fix: snapshots

* test: small fixes
0xng pushed a commit that referenced this pull request Sep 10, 2024
* test: add L2 standard bridge interop unit tests

* fix: add tests natspec

* fix: add generic factory interface
0xng pushed a commit that referenced this pull request Sep 11, 2024
* test: add L2 standard bridge interop unit tests

* fix: add tests natspec

* fix: add generic factory interface
0xng pushed a commit that referenced this pull request Sep 11, 2024
* test: add L2 standard bridge interop unit tests

* fix: add tests natspec

* fix: add generic factory interface
0xng pushed a commit that referenced this pull request Sep 12, 2024
* test: add L2 standard bridge interop unit tests

* fix: add tests natspec

* fix: add generic factory interface
0xng added a commit that referenced this pull request Sep 12, 2024
* test: add L2 standard bridge interop unit tests (#13)

* test: add L2 standard bridge interop unit tests

* fix: add tests natspec

* fix: unit tests fixes

* fix: super to legacy tests failing

* fix: mock and expect mint and burn

* fix: add generic factory interface (#14)

* test: add L2 standard bridge interop unit tests

* fix: add tests natspec

* fix: add generic factory interface

* feat: modify OptimismMintableERC20Factory for convert (#17)

* test: add L2 standard bridge interop unit tests

* fix: add tests natspec

* fix: add generic factory interface

* feat: modify OptimismMintableERC20Factory for convert

* fix: use only a public function for create3

* feat: rollback interop factory, modify legacy one

* fix: delete local token return variable

* fix: PR fixes

* feat: add superchain erc20 factory implementation (#23)

* feat: add superchain erc20 factory implementation

* fix: remove createX comments

* test: add superchain erc20 factory tests (#25)

* test: add superchain erc20 factory tests

* test: add erc20 asserts

* test: fix expect emit

* fix: remove comments

* feat: add constructor to superchain ERC20 beacon (#34)

* test: remove factory predeploy etch

----------

Co-authored-by: 0xng <ng@defi.sucks>
Co-authored-by: 0xParticle <particle@defi.sucks>
Co-authored-by: gotzenx <78360669+gotzenx@users.noreply.github.com>

* fix: set an arbitrary address for superchain erc20 impl

* fix: deploy a proxy for the beacon on genesis (#45)


---------

Co-authored-by: 0xng <ng@defi.sucks>

* fix: conflicts and imports

* fix: interfaces

* chore: add .testdata

* fix: adding back .testdata to gitignore

* fix: new conflicts from ci improvements

---------

Co-authored-by: 0xng <ng@defi.sucks>
Co-authored-by: 0xParticle <particle@defi.sucks>
Co-authored-by: gotzenx <78360669+gotzenx@users.noreply.github.com>
Co-authored-by: Disco <131301107+0xDiscotech@users.noreply.github.com>
agusduha pushed a commit that referenced this pull request Sep 17, 2025
* min-base-fee solidity diffs

* remove codegen bin

* update semver and remove some more diffs in systemconfig codegen

* revert bindings/systemconfig

* e2e test

* spike acceptance-test

* wip acceptance test

* add support for jovian mbf

* op-acceptance-test: min base fee (#14)

* add kurtosis files

* move dsl into test

* passing

* ensure block is progressing

* remove checkfordecrease func

* simulate txs

* nits + simplify

* base + jovian sysgo passes

* sysext passes

* nits + reduce bindings diff

* just wait for 1 block

* use zero addr, and swap test order

* add else clause to e2e test

* use high/med/zero mbfs

* e2e test configure mbf

* check activation block base fee is less than mbf

* wip setting diff mbfs

* claude fix

* build activation+1 block

* simulate some tx on diff med/high mbfs

* wip claude dont use extclient

* use 2gwei, 5gwei too high causes maxFeePerGas error

* sysgo and sysext pass for jovian

* dont default ptr(0) and first nit on action test

* remove user tx in actions

* acceptance-test no user tx + reduce diffs in actions

* kurtosis: run on jovian devnet (#15)

* wip

* pin teku version

* fix TestSystemConfigMarshaling

* fix attribute test + add comment in payload_util
0xiamflux pushed a commit that referenced this pull request Jan 27, 2026
0xOneTony pushed a commit that referenced this pull request Mar 6, 2026
…imism#19281)

* fix(contracts): address audit findings #14, #6, #8, #13, #19

- #14: Reuse existing DelayedWETH from SystemConfig instead of deploying
  a new one in the Migrator, preventing divergence with future upgrades
- #6: Document that hardcoded game type lists in OPCMv2 and Migrator are
  intentional and must be kept in sync when new types are added
- #8: Document that migrate() does not enforce SuperchainConfig version floor
- #13: Document why migration game config validation is deliberately minimal
- #19: Document theoretical risk in AnchorStateRegistry.isGameRegistered
  when ASR proxy is replaced non-atomically

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* fix(contracts): add cross-reference comment to GameTypes library

Add a notice to the GameTypes library reminding developers to update
the hardcoded game type lists in OPContractsManagerMigrator and
OPContractsManagerV2's _assertValidFullConfig when adding new types.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* fix(contracts): bump OPContractsManagerV2 version for rebase

Bump OPContractsManagerV2 from 7.0.9 to 7.0.10 to account for the
comment-only source change (cross-reference note added in prior commit)
that affects the bytecode metadata hash.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* fix(contracts): bump OPContractsManagerV2 version to 7.0.11 for semver-diff CI fix

* fix(contracts): apply forge fmt and bump versions for formatting changes

forge fmt changed OPContractsManager, FaultDisputeGame, SuperFaultDisputeGame,
and several other files. Bump patch versions for the contracts with hash changes,
and regenerate semver-lock and snapshots.

- OPContractsManager: 6.0.3 -> 6.0.4
- FaultDisputeGame: 2.4.0 -> 2.4.1
- SuperFaultDisputeGame: 0.7.0 -> 0.7.1

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Co-authored-by: smartcontracts <smartcontracts@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants