core/txpool/legacypool: data race in checkDelegationLimit#31475
Merged
rjl493456442 merged 3 commits intoethereum:masterfrom Mar 28, 2025
Merged
core/txpool/legacypool: data race in checkDelegationLimit#31475rjl493456442 merged 3 commits intoethereum:masterfrom
rjl493456442 merged 3 commits intoethereum:masterfrom
Conversation
Contributor
Author
Member
|
The data race is theoretically possible but does not occur in practice. The lookup struct can only be modified by |
rjl493456442
previously approved these changes
Mar 24, 2025
Contributor
Author
|
fixed |
rjl493456442
approved these changes
Mar 28, 2025
sidhujag
pushed a commit
to syscoin/go-ethereum
that referenced
this pull request
Mar 28, 2025
sivaratrisrinivas
pushed a commit
to sivaratrisrinivas/go-ethereum
that referenced
this pull request
Apr 21, 2025
sduchesneau
pushed a commit
to streamingfast/go-ethereum
that referenced
this pull request
May 22, 2025
jakub-freebit
pushed a commit
to fblch/go-ethereum
that referenced
this pull request
Jul 3, 2025
howjmay
pushed a commit
to iotaledger/go-ethereum
that referenced
this pull request
Aug 27, 2025
gballet
pushed a commit
to gballet/go-ethereum
that referenced
this pull request
Sep 11, 2025
eomti-wm
added a commit
to stable-net/go-stablenet
that referenced
this pull request
Jan 5, 2026
Add delegationTxsCount method with proper lock to fix data race when accessing auths map in checkDelegationLimit. Based on ethereum/go-ethereum#31475
eomti-wm
added a commit
to stable-net/go-stablenet
that referenced
this pull request
Jan 14, 2026
* chore: update Go version to 1.21 * feat: implement EIP-7702 set code transaction type Add support for EIP-7702 (SetCodeTx) which allows EOAs to temporarily delegate their code execution to another account. Changes include: - Add SetCodeTx (type 0x04) transaction type and Authorization struct - Add anzeonSigner for EIP-7702 transaction signing - Implement delegation designator resolution in EVM - Add EIP-7702 specific gas calculation for CALL variants - Update EXTCODE* opcodes to handle delegation designators - Add prestate tracer support for authorization list - Update t8n tool and tests for SetCodeTx Based on ethereum/go-ethereum#30078 * fix: complete EIP-7702 authorization marshaling and eth_call support Based on ethereum/go-ethereum#30926 * refactor: improve EIP-7702 API naming - Rename Authorization to SetCodeAuthorization - Rename SignAuth to SignSetCode with key-first parameter order Based on ethereum/go-ethereum#30933 * fix: rename SetCodeAuthorization 'v' to 'yParity' The API spec requires the name yParity. Based on: - ethereum/go-ethereum@73a4ecf - ethereum/go-ethereum#30936 * refactor: rename AuthList to SetCodeAuthorizations Use SetCode prefix consistently in internal APIs for the authorization list, as a follow-up to SetCodeAuthorization type renaming. Based on ethereum/go-ethereum#30935 * refactor: change SetCodeTx.ChainID to uint256 Change ChainID field type from uint64 to uint256.Int in SetCodeTx and SetCodeAuthorization for consistency with other chain ID handling. Also removes unused json/gencodec tags from signature value fields in DynamicFeeTx, BlobTx, SetCodeTx, and FeeDelegateDynamicFeeTx. Based on ethereum/go-ethereum#30982 * fix: correct chainId check for anzeonSigner Use zero value check for SetCodeTx chainId validation. This aligns with cancunSigner and londonSigner as well. Based on ethereum/go-ethereum#31032 * fix: initialize ChainID in SetCodeTx copy method ChainID should be properly initialized and copied in the copy() method to prevent nil pointer issues during transaction processing. Based on ethereum/go-ethereum#31054 * refactor: remove EXTCODE* special handling for EIP-7702 EXTCODE* opcodes no longer need special overrides for EIP-7702 delegation designators. The delegation designator is now returned as-is. Implements EIPs#9248. Based on ethereum/go-ethereum#31089 * feat: add EIP-7702 SetCode transaction pool support Add SetCode transaction handling to legacypool: - SetCodeTxType validation with Anzeon fork check - Empty authorization rejection - Authority tracking and conflict prevention - Account slot limit for delegated accounts and pending authorizations Note: tx replacement is not supported in go-stablenet. Tests are adjusted to expect ErrAccountLimitExceeded instead of successful replacement. Based on ethereum/go-ethereum#31073 * test: add setCodeTx reorg test Based on ethereum/go-ethereum#31206 * refactor: move setcode tx validation into legacyPool Move authorization-related validations from common validation to legacyPool since these checks are specific to SetCode transactions. Based on ethereum/go-ethereum#31209 * fix: fix error logs flood caused by removeAuthorities Fix removeAuthorities to only iterate tx's authorities instead of all authorities in the pool. Based on ethereum/go-ethereum#31249 * refactor: reduce allocs in transaction signing Add sigHash method to TxData interface and move hash computation into each tx type, reducing allocations during signature operations. Based on ethereum/go-ethereum#31258 * fix: reject gapped tx from delegated account Add checkDelegationLimit to reject transactions with gapped nonces from delegated accounts. Only one in-flight executable transaction is allowed for senders with delegation or pending delegation. Based on ethereum/go-ethereum#31430 * fix: exclude 7702 authorities from eth_createAccessList result Exclude valid EIP-7702 authorities from access list generation result. Based on ethereum/go-ethereum#31336 (which resolves ethereum/go-ethereum#31335) * fix: data race in checkDelegationLimit Add delegationTxsCount method with proper lock to fix data race when accessing auths map in checkDelegationLimit. Based on ethereum/go-ethereum#31475 * feat: add EIP-7702 protection to blobpool Add delegation limit checks to blobpool: - Limit senders with delegation/pending auth to one in-flight tx - Check reserver for authority conflicts - Refactor AddressReserver to Reserver struct with Hold/Release/Has Based on ethereum/go-ethereum#31526 * fix: slot limit check and update comments - Skip slot limit validation for tx replacements (same nonce reuses slot) - Clarify cumulative balance validation skip reason: fee delegation compatibility * fix: allow tx and authority regardless of admission order Check reserver for authority conflicts to make authorization validation independent of admission order. Authorities must not conflict with addresses reserved by other subpools. Based on ethereum/go-ethereum#31373 * fix: fix data race of txlookup access in test Reset txlookup fields directly with proper locking instead of assigning a new lookup object to avoid data race. Based on ethereum/go-ethereum#31641 * feat: allow passing AuthorizationList to eth_call and eth_estimateGas Add AuthorizationList field to CallMsg and toCallArg to support SetCodeTx in eth_call and eth_estimateGas APIs. Based on ethereum/go-ethereum#31198 * fix: fix data race of pricedList access Use Reheap() instead of assigning a new pricedList to avoid data race when clearing pool state. Based on ethereum/go-ethereum#31758 * fix: resolve incorrect prestate for EIP-7702 authority accounts Before: Authority accounts' prestate showed post-authorization code/storage and incorrect balance/nonce due to wrong capture timing After: Authority accounts' prestate correctly reflects state before SetCodeAuthorization is applied - Refactor EVMLogger to pass env in CaptureTxStart instead of CaptureStart - Capture authority accounts before delegation code (0xef0100...) is set - Preserve original code/storage while restoring only gas from balance * feat: prestate tracer lookup EIP-7702 delegation account Parse and lookup the delegation account if EIP-7702 is enabled in prestate tracer. Implements ethereum/go-ethereum#32078 Based on ethereum/go-ethereum#32080 * refactor: expose sigHash as SigHash for SetCodeAuthorization Rename the private sigHash() method to public SigHash() method to enable external signing (e.g., MPC signing). Based on ethereum/go-ethereum#32298 (which resolves ethereum/go-ethereum#32297) * fix: resolve test failures in tracer and blobpool - Add tracer lifecycle calls in runtime package - Fix EIP-7702 and blobpool test configs * Revert "chore: update Go version to 1.21" This reverts commit 71e90d7. * fix: support AuthorizationList in simulated backend gas estimation
eomti-wm
added a commit
to wemixarchive/go-wbft
that referenced
this pull request
Mar 4, 2026
* chore: update Go version to 1.21 * feat: implement EIP-7702 set code transaction type Add support for EIP-7702 (SetCodeTx) which allows EOAs to temporarily delegate their code execution to another account. Changes include: - Add SetCodeTx (type 0x04) transaction type and Authorization struct - Add anzeonSigner for EIP-7702 transaction signing - Implement delegation designator resolution in EVM - Add EIP-7702 specific gas calculation for CALL variants - Update EXTCODE* opcodes to handle delegation designators - Add prestate tracer support for authorization list - Update t8n tool and tests for SetCodeTx Based on ethereum/go-ethereum#30078 * fix: complete EIP-7702 authorization marshaling and eth_call support Based on ethereum/go-ethereum#30926 * refactor: improve EIP-7702 API naming - Rename Authorization to SetCodeAuthorization - Rename SignAuth to SignSetCode with key-first parameter order Based on ethereum/go-ethereum#30933 * fix: rename SetCodeAuthorization 'v' to 'yParity' The API spec requires the name yParity. Based on: - ethereum/go-ethereum@73a4ecf - ethereum/go-ethereum#30936 * refactor: rename AuthList to SetCodeAuthorizations Use SetCode prefix consistently in internal APIs for the authorization list, as a follow-up to SetCodeAuthorization type renaming. Based on ethereum/go-ethereum#30935 * refactor: change SetCodeTx.ChainID to uint256 Change ChainID field type from uint64 to uint256.Int in SetCodeTx and SetCodeAuthorization for consistency with other chain ID handling. Also removes unused json/gencodec tags from signature value fields in DynamicFeeTx, BlobTx, SetCodeTx, and FeeDelegateDynamicFeeTx. Based on ethereum/go-ethereum#30982 * fix: correct chainId check for anzeonSigner Use zero value check for SetCodeTx chainId validation. This aligns with cancunSigner and londonSigner as well. Based on ethereum/go-ethereum#31032 * fix: initialize ChainID in SetCodeTx copy method ChainID should be properly initialized and copied in the copy() method to prevent nil pointer issues during transaction processing. Based on ethereum/go-ethereum#31054 * refactor: remove EXTCODE* special handling for EIP-7702 EXTCODE* opcodes no longer need special overrides for EIP-7702 delegation designators. The delegation designator is now returned as-is. Implements EIPs#9248. Based on ethereum/go-ethereum#31089 * feat: add EIP-7702 SetCode transaction pool support Add SetCode transaction handling to legacypool: - SetCodeTxType validation with Anzeon fork check - Empty authorization rejection - Authority tracking and conflict prevention - Account slot limit for delegated accounts and pending authorizations Note: tx replacement is not supported in go-stablenet. Tests are adjusted to expect ErrAccountLimitExceeded instead of successful replacement. Based on ethereum/go-ethereum#31073 * test: add setCodeTx reorg test Based on ethereum/go-ethereum#31206 * refactor: move setcode tx validation into legacyPool Move authorization-related validations from common validation to legacyPool since these checks are specific to SetCode transactions. Based on ethereum/go-ethereum#31209 * fix: fix error logs flood caused by removeAuthorities Fix removeAuthorities to only iterate tx's authorities instead of all authorities in the pool. Based on ethereum/go-ethereum#31249 * refactor: reduce allocs in transaction signing Add sigHash method to TxData interface and move hash computation into each tx type, reducing allocations during signature operations. Based on ethereum/go-ethereum#31258 * fix: reject gapped tx from delegated account Add checkDelegationLimit to reject transactions with gapped nonces from delegated accounts. Only one in-flight executable transaction is allowed for senders with delegation or pending delegation. Based on ethereum/go-ethereum#31430 * fix: exclude 7702 authorities from eth_createAccessList result Exclude valid EIP-7702 authorities from access list generation result. Based on ethereum/go-ethereum#31336 (which resolves ethereum/go-ethereum#31335) * fix: data race in checkDelegationLimit Add delegationTxsCount method with proper lock to fix data race when accessing auths map in checkDelegationLimit. Based on ethereum/go-ethereum#31475 * feat: add EIP-7702 protection to blobpool Add delegation limit checks to blobpool: - Limit senders with delegation/pending auth to one in-flight tx - Check reserver for authority conflicts - Refactor AddressReserver to Reserver struct with Hold/Release/Has Based on ethereum/go-ethereum#31526 * fix: slot limit check and update comments - Skip slot limit validation for tx replacements (same nonce reuses slot) - Clarify cumulative balance validation skip reason: fee delegation compatibility * fix: allow tx and authority regardless of admission order Check reserver for authority conflicts to make authorization validation independent of admission order. Authorities must not conflict with addresses reserved by other subpools. Based on ethereum/go-ethereum#31373 * fix: fix data race of txlookup access in test Reset txlookup fields directly with proper locking instead of assigning a new lookup object to avoid data race. Based on ethereum/go-ethereum#31641 * feat: allow passing AuthorizationList to eth_call and eth_estimateGas Add AuthorizationList field to CallMsg and toCallArg to support SetCodeTx in eth_call and eth_estimateGas APIs. Based on ethereum/go-ethereum#31198 * fix: fix data race of pricedList access Use Reheap() instead of assigning a new pricedList to avoid data race when clearing pool state. Based on ethereum/go-ethereum#31758 * fix: resolve incorrect prestate for EIP-7702 authority accounts Before: Authority accounts' prestate showed post-authorization code/storage and incorrect balance/nonce due to wrong capture timing After: Authority accounts' prestate correctly reflects state before SetCodeAuthorization is applied - Refactor EVMLogger to pass env in CaptureTxStart instead of CaptureStart - Capture authority accounts before delegation code (0xef0100...) is set - Preserve original code/storage while restoring only gas from balance * feat: prestate tracer lookup EIP-7702 delegation account Parse and lookup the delegation account if EIP-7702 is enabled in prestate tracer. Implements ethereum/go-ethereum#32078 Based on ethereum/go-ethereum#32080 * refactor: expose sigHash as SigHash for SetCodeAuthorization Rename the private sigHash() method to public SigHash() method to enable external signing (e.g., MPC signing). Based on ethereum/go-ethereum#32298 (which resolves ethereum/go-ethereum#32297) * fix: resolve test failures in tracer and blobpool - Add tracer lifecycle calls in runtime package - Fix EIP-7702 and blobpool test configs * Revert "chore: update Go version to 1.21" This reverts commit 71e90d700023db9fc1e0a272d7ffb9207ede738f. * fix: support AuthorizationList in simulated backend gas estimation
eomti-wm
added a commit
to wemixarchive/go-wbft
that referenced
this pull request
Mar 5, 2026
* feat: EIP-7702 Set Code Transaction support (#42) * chore: update Go version to 1.21 * feat: implement EIP-7702 set code transaction type Add support for EIP-7702 (SetCodeTx) which allows EOAs to temporarily delegate their code execution to another account. Changes include: - Add SetCodeTx (type 0x04) transaction type and Authorization struct - Add anzeonSigner for EIP-7702 transaction signing - Implement delegation designator resolution in EVM - Add EIP-7702 specific gas calculation for CALL variants - Update EXTCODE* opcodes to handle delegation designators - Add prestate tracer support for authorization list - Update t8n tool and tests for SetCodeTx Based on ethereum/go-ethereum#30078 * fix: complete EIP-7702 authorization marshaling and eth_call support Based on ethereum/go-ethereum#30926 * refactor: improve EIP-7702 API naming - Rename Authorization to SetCodeAuthorization - Rename SignAuth to SignSetCode with key-first parameter order Based on ethereum/go-ethereum#30933 * fix: rename SetCodeAuthorization 'v' to 'yParity' The API spec requires the name yParity. Based on: - ethereum/go-ethereum@73a4ecf - ethereum/go-ethereum#30936 * refactor: rename AuthList to SetCodeAuthorizations Use SetCode prefix consistently in internal APIs for the authorization list, as a follow-up to SetCodeAuthorization type renaming. Based on ethereum/go-ethereum#30935 * refactor: change SetCodeTx.ChainID to uint256 Change ChainID field type from uint64 to uint256.Int in SetCodeTx and SetCodeAuthorization for consistency with other chain ID handling. Also removes unused json/gencodec tags from signature value fields in DynamicFeeTx, BlobTx, SetCodeTx, and FeeDelegateDynamicFeeTx. Based on ethereum/go-ethereum#30982 * fix: correct chainId check for anzeonSigner Use zero value check for SetCodeTx chainId validation. This aligns with cancunSigner and londonSigner as well. Based on ethereum/go-ethereum#31032 * fix: initialize ChainID in SetCodeTx copy method ChainID should be properly initialized and copied in the copy() method to prevent nil pointer issues during transaction processing. Based on ethereum/go-ethereum#31054 * refactor: remove EXTCODE* special handling for EIP-7702 EXTCODE* opcodes no longer need special overrides for EIP-7702 delegation designators. The delegation designator is now returned as-is. Implements EIPs#9248. Based on ethereum/go-ethereum#31089 * feat: add EIP-7702 SetCode transaction pool support Add SetCode transaction handling to legacypool: - SetCodeTxType validation with Anzeon fork check - Empty authorization rejection - Authority tracking and conflict prevention - Account slot limit for delegated accounts and pending authorizations Note: tx replacement is not supported in go-stablenet. Tests are adjusted to expect ErrAccountLimitExceeded instead of successful replacement. Based on ethereum/go-ethereum#31073 * test: add setCodeTx reorg test Based on ethereum/go-ethereum#31206 * refactor: move setcode tx validation into legacyPool Move authorization-related validations from common validation to legacyPool since these checks are specific to SetCode transactions. Based on ethereum/go-ethereum#31209 * fix: fix error logs flood caused by removeAuthorities Fix removeAuthorities to only iterate tx's authorities instead of all authorities in the pool. Based on ethereum/go-ethereum#31249 * refactor: reduce allocs in transaction signing Add sigHash method to TxData interface and move hash computation into each tx type, reducing allocations during signature operations. Based on ethereum/go-ethereum#31258 * fix: reject gapped tx from delegated account Add checkDelegationLimit to reject transactions with gapped nonces from delegated accounts. Only one in-flight executable transaction is allowed for senders with delegation or pending delegation. Based on ethereum/go-ethereum#31430 * fix: exclude 7702 authorities from eth_createAccessList result Exclude valid EIP-7702 authorities from access list generation result. Based on ethereum/go-ethereum#31336 (which resolves ethereum/go-ethereum#31335) * fix: data race in checkDelegationLimit Add delegationTxsCount method with proper lock to fix data race when accessing auths map in checkDelegationLimit. Based on ethereum/go-ethereum#31475 * feat: add EIP-7702 protection to blobpool Add delegation limit checks to blobpool: - Limit senders with delegation/pending auth to one in-flight tx - Check reserver for authority conflicts - Refactor AddressReserver to Reserver struct with Hold/Release/Has Based on ethereum/go-ethereum#31526 * fix: slot limit check and update comments - Skip slot limit validation for tx replacements (same nonce reuses slot) - Clarify cumulative balance validation skip reason: fee delegation compatibility * fix: allow tx and authority regardless of admission order Check reserver for authority conflicts to make authorization validation independent of admission order. Authorities must not conflict with addresses reserved by other subpools. Based on ethereum/go-ethereum#31373 * fix: fix data race of txlookup access in test Reset txlookup fields directly with proper locking instead of assigning a new lookup object to avoid data race. Based on ethereum/go-ethereum#31641 * feat: allow passing AuthorizationList to eth_call and eth_estimateGas Add AuthorizationList field to CallMsg and toCallArg to support SetCodeTx in eth_call and eth_estimateGas APIs. Based on ethereum/go-ethereum#31198 * fix: fix data race of pricedList access Use Reheap() instead of assigning a new pricedList to avoid data race when clearing pool state. Based on ethereum/go-ethereum#31758 * fix: resolve incorrect prestate for EIP-7702 authority accounts Before: Authority accounts' prestate showed post-authorization code/storage and incorrect balance/nonce due to wrong capture timing After: Authority accounts' prestate correctly reflects state before SetCodeAuthorization is applied - Refactor EVMLogger to pass env in CaptureTxStart instead of CaptureStart - Capture authority accounts before delegation code (0xef0100...) is set - Preserve original code/storage while restoring only gas from balance * feat: prestate tracer lookup EIP-7702 delegation account Parse and lookup the delegation account if EIP-7702 is enabled in prestate tracer. Implements ethereum/go-ethereum#32078 Based on ethereum/go-ethereum#32080 * refactor: expose sigHash as SigHash for SetCodeAuthorization Rename the private sigHash() method to public SigHash() method to enable external signing (e.g., MPC signing). Based on ethereum/go-ethereum#32298 (which resolves ethereum/go-ethereum#32297) * fix: resolve test failures in tracer and blobpool - Add tracer lifecycle calls in runtime package - Fix EIP-7702 and blobpool test configs * Revert "chore: update Go version to 1.21" This reverts commit 71e90d700023db9fc1e0a272d7ffb9207ede738f. * fix: support AuthorizationList in simulated backend gas estimation * internal/ethapi: include AuthorizationList in gas estimation (#33849) Fixes an issue where AuthorizationList wasn't copied over when estimating gas for a user-provided transaction. * test: fix EIP-7702 t8n test expected output * refactor: remove redundant nil check --------- Co-authored-by: vickkkkkyy <vickyaviles847@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.