Skip to content

fix(tests): call delegation access disambiguation#2882

Merged
fselmo merged 1 commit into
ethereum:forks/amsterdamfrom
gurukamath:fix-delegated-account-in-bal
May 19, 2026
Merged

fix(tests): call delegation access disambiguation#2882
fselmo merged 1 commit into
ethereum:forks/amsterdamfrom
gurukamath:fix-delegated-account-in-bal

Conversation

@gurukamath

@gurukamath gurukamath commented May 19, 2026

Copy link
Copy Markdown
Contributor

🗒️ Description

CALL with insufficient balance shoudn't access delegation

🔗 Related Issues or PRs

#2473

✅ Checklist

  • All: Ran fast static checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    just static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).

call with insufficient balance shoudn't access delegation

@fselmo fselmo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lgtm 👍🏼

@codecov

codecov Bot commented May 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.16%. Comparing base (84b22c0) to head (b988ff4).
⚠️ Report is 1 commits behind head on forks/amsterdam.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           forks/amsterdam    #2882      +/-   ##
===================================================
- Coverage            89.74%   87.16%   -2.58%     
===================================================
  Files                  487      586      +99     
  Lines                28902    35791    +6889     
  Branches              2623     3364     +741     
===================================================
+ Hits                 25937    31198    +5261     
- Misses                2450     3943    +1493     
- Partials               515      650     +135     
Flag Coverage Δ
unittests 87.16% <ø> (-2.58%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fselmo fselmo merged commit 62b914c into ethereum:forks/amsterdam May 19, 2026
18 checks passed
fselmo added a commit to fselmo/execution-specs that referenced this pull request May 19, 2026
@fselmo fselmo mentioned this pull request May 19, 2026
7 tasks
fselmo added a commit that referenced this pull request May 20, 2026
* test(tests): extend BALs coverage for edge cases

* test(tests): closes #1910 - parametrize memory for call_opcode tests

* test(tests): expand BAL coverage for insufficient-funds boundaries

Add a combined outer-REVERT + inner-insufficient-funds test (CALL and CREATE), and layer EIP-7928-gated BAL expectations onto three existing cross-fork insufficient-funds tests (EIP-7708, EIP-2929 frontier CALL).

* feat(tests): add some more parallelization test scenarios for BALs

* chore(tests): add SSTORE to CREATE2 + SD + re-create as sanity check

* cleanups from comments on PR #2854

* feat(tests): add parallelization BAL tests for collision / OOG create chain

* chore: audit * update ``test_cases.md`` after suggestions and PR #2882

* fix(tests): update expected exception(s) for transition tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants