feat(tests): extend BALs coverage#2854
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #2854 +/- ##
===================================================
+ Coverage 87.16% 90.44% +3.27%
===================================================
Files 586 535 -51
Lines 35791 32439 -3352
Branches 3364 3012 -352
===================================================
- Hits 31198 29338 -1860
+ Misses 3943 2573 -1370
+ Partials 650 528 -122
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
5d3d0f3 to
1a41583
Compare
1a41583 to
d47d5fc
Compare
Add a combined outer-REVERT + inner-insufficient-funds test (CALL and CREATE), and layer EIP-7928-gated BAL expectations onto three existing cross-fork insufficient-funds tests (EIP-7708, EIP-2929 frontier CALL).
505bafc to
4ba4a6a
Compare
|
Last 3 commits here should address your comments @raxhvl. I added a bit more to the extra test case as parallelization create chain variants, I think it's a good case. Please re-review when you get a chance. In the last commit, I did a fresh audit of |
|
Context on the last commit here, stems from recently merged transition tests and this conversation on STEEL Discord server. |
kclowes
left a comment
There was a problem hiding this comment.
LGTM from my limited view. Nothing obvious stands out!
🗒️ Description
This branch closes BAL coverage gaps that surfaced while drafting the EIP-7928 testing checklist (subsequent PR) and resolves #1910 along the way. The goal here is to get closer to full BAL coverage ahead of the checklist.
Additional parallelization tests (fourth commit)
Builds a bit on #2851 tests
test_bal_cross_tx_factory_nonce_create_chain: 8 distinct senders each call a shared factory'sCREATEwith identical initcode. Probes parallelizers that skipnonce_changeswhen there are no storage/balance signals; they'd collide all 8 deployments onaddr(factory, N+1).test_bal_7702_delegation_update: Two txs from distinct relayers both auth alice's delegation (nonces 0, 1). Probes parallel auth-signature verifiers that validate the second auth against pre-block alice.nonce=0, rejecting it instead of seeing the post-tx-1 bump.✅ Checklist
just statictype(scope):.mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.@ported_frommarker.Cute Animal Picture