Skip to content

docs:fix Documentation for calculate_block_difficulty incorrectly ref…#1673

Merged
SamWilsn merged 1 commit into
ethereum:forks/osakafrom
pheobeayo:fix-#607
Oct 24, 2025
Merged

docs:fix Documentation for calculate_block_difficulty incorrectly ref…#1673
SamWilsn merged 1 commit into
ethereum:forks/osakafrom
pheobeayo:fix-#607

Conversation

@pheobeayo

@pheobeayo pheobeayo commented Oct 24, 2025

Copy link
Copy Markdown
Contributor

…erences GENESIS_DIFFICULTY

🗒️ Description

🔗 Related Issues or PRs

fixes #607

✅ Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks: 
    uvx tox -e static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered adding an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.
  • Tests: For PRs implementing a missed test case, update the post-mortem document to add an entry the list.
  • Ported Tests: All converted JSON/YML tests from ethereum/tests or tests/static have been assigned @ported_from marker.

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@pheobeayo pheobeayo mentioned this pull request Oct 24, 2025
Closed
8 tasks
@pheobeayo

pheobeayo commented Oct 24, 2025

Copy link
Copy Markdown
Contributor Author

@SamWilsn This is a new PR I have created against this #1464 which I created earlier, Please review

kclowes pushed a commit to kclowes/execution-specs that referenced this pull request Oct 24, 2025
@richardgreg @marioevz
refactor(fw): move TransactionType enum to ethereum_test_types module (…
0a6470e 
…ethereum#1673)

* refactor(fw): move TransactionType enum to ethereum_test_types module

* fix: tox

---------

Co-authored-by: Mario Vega <marioevz@gmail.com>
@SamWilsn SamWilsn merged commit 0477966 into ethereum:forks/osaka Oct 24, 2025
10 of 11 checks passed
@codecov-commenter

codecov-commenter commented Oct 25, 2025

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.07%. Comparing base (da0c26e) to head (aa5a4db).
⚠️ Report is 6 commits behind head on forks/osaka.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@               Coverage Diff               @@
##           forks/osaka    #1673      +/-   ##
===============================================
- Coverage        86.08%   86.07%   -0.02%     
===============================================
  Files              743      743              
  Lines            44072    44078       +6     
  Branches          3891     3894       +3     
===============================================
  Hits             37938    37938              
- Misses            5656     5659       +3     
- Partials           478      481       +3
Flag Coverage Δ
unittests 86.07% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

SamWilsn pushed a commit that referenced this pull request Dec 9, 2025
@richardgreg @marioevz
refactor(fw): move TransactionType enum to ethereum_test_types module (…
ced7ad1 
…#1673)

* refactor(fw): move TransactionType enum to ethereum_test_types module

* fix: tox

---------

Co-authored-by: Mario Vega <marioevz@gmail.com>
SamWilsn pushed a commit that referenced this pull request Dec 9, 2025
@richardgreg @marioevz
refactor(fw): move TransactionType enum to ethereum_test_types module (…
c4d39af 
…#1673)

* refactor(fw): move TransactionType enum to ethereum_test_types module

* fix: tox

---------

Co-authored-by: Mario Vega <marioevz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SamWilsn SamWilsn SamWilsn approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Documentation for calculate_block_difficulty incorrectly references GENESIS_DIFFICULTY

3 participants

@pheobeayo @codecov-commenter @SamWilsn