Skip to content

docs:fix Documentation for calculate_block_difficulty incorrectly references GENESIS_DIFFICULTY#1464

Closed
pheobeayo wants to merge 1 commit into
ethereum:forks/osakafrom
pheobeayo:fix-#607
Closed

docs:fix Documentation for calculate_block_difficulty incorrectly references GENESIS_DIFFICULTY#1464
pheobeayo wants to merge 1 commit into
ethereum:forks/osakafrom
pheobeayo:fix-#607

Conversation

@pheobeayo

@pheobeayo pheobeayo commented Oct 8, 2025

Copy link
Copy Markdown
Contributor

🗒️ Description

Documentation: fix documentation for calculate_block_difficulty incorrectly references GENESIS_DIFFICULTY

🔗 Related Issues or PRs

#607

✅ Checklist

fixes #607

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlint
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered adding an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.
  • Tests: For PRs implementing a missed test case, update the post-mortem document to add an entry the list.
  • Ported Tests: All converted JSON/YML tests from ethereum/tests or tests/static have been assigned @ported_from marker.

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@pheobeayo

Copy link
Copy Markdown
Contributor Author

@SamWilsn, Please kindly review this PR

@SamWilsn

Copy link
Copy Markdown
Contributor

Looks good! Could you make the same change to the other forks?

@pheobeayo

Copy link
Copy Markdown
Contributor Author

Looks good! Could you make the same change to the other forks?

Okay, on it

@pheobeayo

Copy link
Copy Markdown
Contributor Author

@SamWilsn could you merge this PR, then I will make another fork of this repo that contains all other forks, because this present fork I made only forked the default fork?

Will that work? Then I will gladly work on others as soon as that is done

@pheobeayo pheobeayo closed this by deleting the head repository Oct 24, 2025
@pheobeayo

Copy link
Copy Markdown
Contributor Author

@SamWilsn I have created a new PR for this here , I misunderstood your review and I had to delete my fork but I have fixed the issue for other forks as you requested
#1673

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Documentation for calculate_block_difficulty incorrectly references GENESIS_DIFFICULTY

2 participants