Skip to content

fix(types,tests): EIP-7685 fixes for devnet-5#990

Merged
spencer-tb merged 4 commits intomainfrom
eip-7685-devnet-5
Dec 4, 2024
Merged

fix(types,tests): EIP-7685 fixes for devnet-5#990
spencer-tb merged 4 commits intomainfrom
eip-7685-devnet-5

Conversation

@marioevz
Copy link
Copy Markdown
Member

@marioevz marioevz commented Dec 4, 2024

🗒️ Description

Addresses changes in ethereum/EIPs#8989 and ethereum/execution-apis#599 for devnet-5 by removing the empty requests from the requests list in the computation of the commitment.

Requires ethereum/execution-specs#1046

🔗 Related Issues

#956

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@marioevz marioevz added scope:forks Scope: Changes ethereum_test_forks package scope:tests Scope: Changes EL client test cases in `./tests` scope:fw Scope: Framework (evm|tools|forks|pytest) labels Dec 4, 2024
@spencer-tb spencer-tb mentioned this pull request Dec 4, 2024
Closed
spencer-tb
spencer-tb approved these changes Dec 4, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@spencer-tb spencer-tb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Empty hash LGTM!

Taking a look at the tests :D

@spencer-tb spencer-tb merged commit 5a40172 into main Dec 4, 2024
@spencer-tb spencer-tb deleted the eip-7685-devnet-5 branch December 4, 2024 10:19
@pdobacz pdobacz mentioned this pull request Dec 18, 2024
Merged
8 tasks
kclowes pushed a commit to kclowes/execution-spec-tests that referenced this pull request Oct 20, 2025
@marioevz @spencer-tb
fix(types,tests): EIP-7685 fixes for devnet-5 (ethereum#990)
1a87ddf 
* fix(forks): Update EIP-7002, EIP-7251 contracts

* fix(types): Remove empty requests from list

* fix(tests): Remove empty requests from lists in all tests

* chore: tox black fix.

---------

Co-authored-by: spencer-tb <spencer@spencertaylorbrown.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spencer-tb spencer-tb spencer-tb approved these changes

Assignees

@marioevz marioevz

Labels

scope:forks Scope: Changes ethereum_test_forks package scope:fw Scope: Framework (evm|tools|forks|pytest) scope:tests Scope: Changes EL client test cases in `./tests`

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@marioevz @spencer-tb