EIP-7685: exclude empty requests in requests list#1046
EIP-7685: exclude empty requests in requests list#1046petertdavies merged 3 commits intoethereum:devnets/prague/5from
Conversation
|
I see that the tox issue is from running our latest generated blockchain tests, which makes sense since we are altering the expected hash in the header of any Prague test, but to generate a new set of tests we need this PR. It's an interesting dependency problem. |
|
Can you generate and release new tests before this is merged, or should I force merge this? |
I think our option could be to combine all required branches into a temporary |
|
This has now been pointed at the |
* feat(forks,tests): EIP-2935: Contract update * Update tests/prague/eip2935_historical_block_hashes_from_state/test_contract_deployment.py Co-authored-by: danceratopz <danceratopz@gmail.com> * fix: Add storage hint * refactor(tools): Use `Block` instead of `Tuple` * fix(tools): pass test_type * new(tests): Add block hash checking on deployment test --------- Co-authored-by: danceratopz <danceratopz@gmail.com>
* feat(forks,tests): EIP-2935: Contract update * Update tests/prague/eip2935_historical_block_hashes_from_state/test_contract_deployment.py Co-authored-by: danceratopz <danceratopz@gmail.com> * fix: Add storage hint * refactor(tools): Use `Block` instead of `Tuple` * fix(tools): pass test_type * new(tests): Add block hash checking on deployment test --------- Co-authored-by: danceratopz <danceratopz@gmail.com>
What was wrong?
The following PRs include breaking changes in the behavior of requests for devnet-5:
ethereum/execution-apis#599
ethereum/EIPs#8989
How was it fixed?
Remove requests elements from the requests list if the byte array is empty.
Also do not remove the
request_typebyte in the return list of the T8N result since it's now necessary to calculate the requests commitment.Cute Animal Picture