Add testing_buildBlockV1 RPC Method#747
Merged
Merged
Conversation
…ures This commit adds comprehensive support for the testing_buildBlockV1 RPC method, which is used to generate test fixtures for Ethereum execution layer clients. Changes include: - New OpenRPC specification in src/testing/testing_buildBlockV1.yaml - Test fixtures for three scenarios: with transactions, with extra data, without extra data - Integration of testing methods into spec build process (scripts/build.js) - Client configuration to enable testing RPC namespace (tools/client.go) - Test generator implementation with comprehensive validation (tools/testgen/generators.go) - Wordlist update for spellcheck compliance All tests pass: ✅ npm run lint (OpenRPC validation) ✅ npm run test (speccheck validation) ✅ Spellcheck The implementation follows existing patterns and is backward compatible.
Contributor
Author
|
This PR is in draft mostly because of the requirement to use MariusVanDerWijden/testing-buildblock and it is directly addressing testing for #710 as well as some other minor issues found while running the complete test suite. Also, I'm getting some errors with the branch/fork of geth, which I think are actual geth bugs. |
Contributor
Author
|
Ok, now the tests are passing, but these changes still need to make it into go-ethereum |
Contributor
Author
|
I removed one of the tests because it was redundant. The tests cover all scenarios:
It also validates the go-ethereum responses to the spec to avoid regressions in the library |
Contributor
Author
|
Updated reference to the latest, spec now allows passing |
4 tasks
10 tasks
Resolve conflicts: - package.json: accept main's make-based build commands - scripts/build.js: delete (replaced by Go specgen tool) - tools/go.mod: accept main's deps, keep replace directive for geth fork - tools/go.sum: regenerated via go mod tidy - Makefile: add -methods 'src/testing' for testing_buildBlockV1
7 tasks
10 tasks
7 tasks
4 tasks
Update testing_buildBlockV1 fixture outputs to match current fill results, including slotNumber and blockTimestamp fields.
Contributor
Author
|
@fjl can merge |
4 tasks
2 tasks
github-merge-queue Bot
pushed a commit
to erigontech/erigon
that referenced
this pull request
Apr 7, 2026
## Summary Pin `ethereum/execution-apis` ref in hive rpc-compat tests, the same way `hive_ref` already pins the hive framework itself. - Add `execution_apis_ref` to `hive-versions.json` - Before hive builds the rpc-compat simulator image, clone execution-apis at the pinned ref, copy the `tests/` dir into the build context, and patch the Dockerfile to use the local copy (the Dockerfile already has a commented-out `ADD tests` for this purpose) - Only runs for the `rpc/compat` matrix entry, not engine sims ## Why The rpc-compat simulator's Dockerfile clones `ethereum/execution-apis` at `main` HEAD on every build (`ARG branch=main`). On April 6 at ~15:00 UTC, ethereum/execution-apis#747 added `testing_buildBlockV1` tests (200 → 208 tests). Erigon doesn't implement this method, causing 4 new failures and breaking ci-gate on **all PRs**. The hive framework was already pinned via `hive_ref`, but the test data it fetches was not. To bump execution-apis in the future, update `execution_apis_ref` in `hive-versions.json`. ## Test plan - [ ] ci-gate passes (rpc-compat runs pinned 200 tests, 0 failures) - [ ] Engine sims unaffected (step is skipped via matrix condition) --------- Co-authored-by: yperbasis <andrey.ashikhmin@gmail.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-merge-queue Bot
pushed a commit
to erigontech/erigon
that referenced
this pull request
Apr 7, 2026
## Summary Pin `ethereum/execution-apis` ref in hive rpc-compat tests, the same way `hive_ref` already pins the hive framework itself. - Add `execution_apis_ref` to `hive-versions.json` - Before hive builds the rpc-compat simulator image, clone execution-apis at the pinned ref, copy the `tests/` dir into the build context, and patch the Dockerfile to use the local copy (the Dockerfile already has a commented-out `ADD tests` for this purpose) - Only runs for the `rpc/compat` matrix entry, not engine sims ## Why The rpc-compat simulator's Dockerfile clones `ethereum/execution-apis` at `main` HEAD on every build (`ARG branch=main`). On April 6 at ~15:00 UTC, ethereum/execution-apis#747 added `testing_buildBlockV1` tests (200 → 208 tests). Erigon doesn't implement this method, causing 4 new failures and breaking ci-gate on **all PRs**. The hive framework was already pinned via `hive_ref`, but the test data it fetches was not. To bump execution-apis in the future, update `execution_apis_ref` in `hive-versions.json`. ## Test plan - [ ] ci-gate passes (rpc-compat runs pinned 200 tests, 0 failures) - [ ] Engine sims unaffected (step is skipped via matrix condition) --------- Co-authored-by: yperbasis <andrey.ashikhmin@gmail.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
AskAlexSharov
added a commit
to erigontech/erigon
that referenced
this pull request
Apr 8, 2026
Pin `ethereum/execution-apis` ref in hive rpc-compat tests, the same way `hive_ref` already pins the hive framework itself. - Add `execution_apis_ref` to `hive-versions.json` - Before hive builds the rpc-compat simulator image, clone execution-apis at the pinned ref, copy the `tests/` dir into the build context, and patch the Dockerfile to use the local copy (the Dockerfile already has a commented-out `ADD tests` for this purpose) - Only runs for the `rpc/compat` matrix entry, not engine sims The rpc-compat simulator's Dockerfile clones `ethereum/execution-apis` at `main` HEAD on every build (`ARG branch=main`). On April 6 at ~15:00 UTC, ethereum/execution-apis#747 added `testing_buildBlockV1` tests (200 → 208 tests). Erigon doesn't implement this method, causing 4 new failures and breaking ci-gate on **all PRs**. The hive framework was already pinned via `hive_ref`, but the test data it fetches was not. To bump execution-apis in the future, update `execution_apis_ref` in `hive-versions.json`. - [ ] ci-gate passes (rpc-compat runs pinned 200 tests, 0 failures) - [ ] Engine sims unaffected (step is skipped via matrix condition) --------- Co-authored-by: yperbasis <andrey.ashikhmin@gmail.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
14 tasks
Member
|
I was not aware that this was the active one for this endpoint, I went to #710. There are some requests, this one in particular, which I'd like to see in this API. It is about adding the target gas limit to the API, to have control over the gas target of the block. This is necessary to fill certain benchmarks (for instance a mainnet fork where we want to bump the gas limit to twice the current value, and then create benchmark blocks) |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds comprehensive support for the testing_buildBlockV1 RPC method.
Changes
Testing Results
✅ All npm lint checks passing
✅ All speccheck tests passing
✅ Spellcheck validation passing