hive: pin more things#20370
Merged
Merged
Conversation
2 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
Pins the upstream ethereum/execution-apis test data used by Hive’s rpc-compat simulator to keep CI stable when upstream adds/changes tests.
Changes:
- Add
execution_apis_refto.github/workflows/hive-versions.jsonalongside the existing pinnedhive_ref. - Update
test-hive.ymlto readexecution_apis_refand (for rpc-compat) replace the simulator’s execution-apis checkout behavior by copying pinnedtests/into the simulator and editing its Dockerfile.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| .github/workflows/test-hive.yml | Reads pinned versions and conditionally pins rpc-compat’s execution-apis tests by modifying the simulator inputs. |
| .github/workflows/hive-versions.json | Adds a pinned execution_apis_ref commit SHA. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
yperbasis
approved these changes
Apr 7, 2026
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
5 tasks
AskAlexSharov
added a commit
that referenced
this pull request
Apr 8, 2026
Pin `ethereum/execution-apis` ref in hive rpc-compat tests, the same way `hive_ref` already pins the hive framework itself. - Add `execution_apis_ref` to `hive-versions.json` - Before hive builds the rpc-compat simulator image, clone execution-apis at the pinned ref, copy the `tests/` dir into the build context, and patch the Dockerfile to use the local copy (the Dockerfile already has a commented-out `ADD tests` for this purpose) - Only runs for the `rpc/compat` matrix entry, not engine sims The rpc-compat simulator's Dockerfile clones `ethereum/execution-apis` at `main` HEAD on every build (`ARG branch=main`). On April 6 at ~15:00 UTC, ethereum/execution-apis#747 added `testing_buildBlockV1` tests (200 → 208 tests). Erigon doesn't implement this method, causing 4 new failures and breaking ci-gate on **all PRs**. The hive framework was already pinned via `hive_ref`, but the test data it fetches was not. To bump execution-apis in the future, update `execution_apis_ref` in `hive-versions.json`. - [ ] ci-gate passes (rpc-compat runs pinned 200 tests, 0 failures) - [ ] Engine sims unaffected (step is skipped via matrix condition) --------- Co-authored-by: yperbasis <andrey.ashikhmin@gmail.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
AskAlexSharov
added a commit
that referenced
this pull request
Apr 8, 2026
## Summary - Cherry-pick of #20370 --------- Co-authored-by: yperbasis <andrey.ashikhmin@gmail.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: Muzry <muzrry@gmail.com> Co-authored-by: muzry.li <muzry.li1@ambergroup.io>
AskAlexSharov
added a commit
that referenced
this pull request
Apr 8, 2026
- Cherry-pick of #20370 --------- Co-authored-by: yperbasis <andrey.ashikhmin@gmail.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: Muzry <muzrry@gmail.com> Co-authored-by: muzry.li <muzry.li1@ambergroup.io>
AskAlexSharov
added a commit
that referenced
this pull request
Apr 13, 2026
- Cherry-pick of #20370 --------- Co-authored-by: yperbasis <andrey.ashikhmin@gmail.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: Muzry <muzrry@gmail.com> Co-authored-by: muzry.li <muzry.li1@ambergroup.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pin
ethereum/execution-apisref in hive rpc-compat tests, the same wayhive_refalready pins the hive framework itself.execution_apis_reftohive-versions.jsontests/dir into the build context, and patch the Dockerfile to use the local copy (the Dockerfile already has a commented-outADD testsfor this purpose)rpc/compatmatrix entry, not engine simsWhy
The rpc-compat simulator's Dockerfile clones
ethereum/execution-apisatmainHEAD on every build (ARG branch=main). On April 6 at ~15:00 UTC, ethereum/execution-apis#747 addedtesting_buildBlockV1tests (200 → 208 tests). Erigon doesn't implement this method, causing 4 new failures and breaking ci-gate on all PRs.The hive framework was already pinned via
hive_ref, but the test data it fetches was not.To bump execution-apis in the future, update
execution_apis_refinhive-versions.json.Test plan