Update EIP-7685: group requests into request-data#8924
Merged
eth-bot merged 1 commit intoethereum:masterfrom Oct 7, 2024
Merged
Update EIP-7685: group requests into request-data#8924eth-bot merged 1 commit intoethereum:masterfrom
eth-bot merged 1 commit intoethereum:masterfrom
Conversation
Collaborator
|
✅ All reviewers have approved. |
e402996 to
2dfa06a
Compare
eth-bot
approved these changes
Oct 7, 2024
Collaborator
eth-bot
left a comment
There was a problem hiding this comment.
All Reviewers Have Approved; Performing Automatic Merge...
mkalinin
reviewed
Oct 8, 2024
| def compute_requests_hash(requests): | ||
| m = sha256() | ||
| for r in requests: | ||
| m.update(sha256(r)) |
Contributor
There was a problem hiding this comment.
According to the PR’s description, there is a type byte hashed in front of every list. In this particular case not having a “domain” byte is fine because the order already does this implicitly. Just want to confirm this algo in the spec is the one that it was intended to be
Member
Author
There was a problem hiding this comment.
maybe not the clearest, but each r in requests is the prefixed data already
3 tasks
12 tasks
4 tasks
8 tasks
This was referenced Oct 16, 2024
yperbasis
pushed a commit
to erigontech/erigon
that referenced
this pull request
Oct 22, 2024
Header data will contain this different name now Ref: ethereum/EIPs#8924 Issue board: #12106
somnergy
added a commit
to erigontech/erigon
that referenced
this pull request
Oct 23, 2024
Summary of changes - Remove `Requests` interface in favour of new `FlatRequest` struct - Add changes for new `RequestHash` calculation that `sha256` digests the set of flat requests - Remove `Requests` from block and body related structs and methods - Set of requests that gets pulled at the `Finalize` stage is now returned from there, both for execution and block-building Ref1: ethereum/execution-apis#591 Ref2: ethereum/EIPs#8854 Ref3: ethereum/EIPs#8924 Needs interface change - erigontech/interfaces#239 (Tasks board - #12106)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hopefully this encapsulates the discussion on discord and in #8916.
Essentially, we now refer to
request_dataas the opaque data output by the system contract instead of a request's individual fields and we modify therequest_hashcalculation to be the following: