Conversation
yperbasis
approved these changes
Oct 23, 2024
somnergy
added a commit
to erigontech/erigon
that referenced
this pull request
Oct 23, 2024
Summary of changes - Remove `Requests` interface in favour of new `FlatRequest` struct - Add changes for new `RequestHash` calculation that `sha256` digests the set of flat requests - Remove `Requests` from block and body related structs and methods - Set of requests that gets pulled at the `Finalize` stage is now returned from there, both for execution and block-building Ref1: ethereum/execution-apis#591 Ref2: ethereum/EIPs#8854 Ref3: ethereum/EIPs#8924 Needs interface change - erigontech/interfaces#239 (Tasks board - #12106)
yperbasis
pushed a commit
that referenced
this pull request
Oct 24, 2024
* Flatten 7251 req * Replace requests with generic requests * fix type * change byte to uint8 * Simplify requests bundle * Rename requests_hash and remove reqs from body
Merged
yperbasis
added a commit
that referenced
this pull request
Oct 24, 2024
mininny
pushed a commit
to testinprod-io/erigon-interfaces
that referenced
this pull request
Feb 11, 2025
* Flatten 7251 req * Replace requests with generic requests * fix type * change byte to uint8 * Simplify requests bundle * Rename requests_hash and remove reqs from body Co-authored-by: Somnath <snb895@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.