Skip to content

Reinstate link checking for preview builds#336

Merged
chalin merged 1 commit intomainfrom
chalin-check-links-2021-05-27
May 27, 2021
Merged

Reinstate link checking for preview builds#336
chalin merged 1 commit intomainfrom
chalin-check-links-2021-05-27

Conversation

@chalin
Copy link
Copy Markdown
Contributor

@chalin chalin commented May 27, 2021

This PR allows us to keep using htmltest for now by tricking it into believing our two main path aliases exist (we create symlinks in a copy of the build).

@chalin chalin added the infrastructure Categorizes issue or PR as related to site infrastructure. label May 27, 2021
@chalin chalin requested a review from nate-double-u May 27, 2021 22:47
@chalin
Copy link
Copy Markdown
Contributor Author

chalin commented May 27, 2021

Maybe we should let this PR close #307 for now? WDYT @nate-double-u?

chalin
chalin commented May 27, 2021
View reviewed changes
nate-double-u
nate-double-u approved these changes May 27, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@nate-double-u nate-double-u left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The deploy log looks good with this method. I think this can close #307, once we rebase for the install page PR (#333).

@chalin chalin force-pushed the chalin-check-links-2021-05-27 branch from 6f0d230 to 24d8b0e Compare May 27, 2021 22:58
@chalin chalin force-pushed the chalin-check-links-2021-05-27 branch from 24d8b0e to 3e2a11f Compare May 27, 2021 23:01
This was referenced May 27, 2021
Open
Open
@chalin
Copy link
Copy Markdown
Contributor Author

chalin commented May 27, 2021

Rebased and pushed.

@chalin
Copy link
Copy Markdown
Contributor Author

chalin commented May 27, 2021

From the build log:

7:02:31 PM: htmltest started at 11:02:31 on public.htmltest
7:02:31 PM: ========================================================================
7:02:33 PM: ✔✔✔ passed in 2.040544873s
7:02:33 PM: tested 404 documents
7:02:33 PM: rm -Rf public.htmltest

@chalin chalin merged commit adbedb6 into main May 27, 2021
@chalin chalin deleted the chalin-check-links-2021-05-27 branch May 27, 2021 23:04
@nate-double-u
Copy link
Copy Markdown
Contributor

nate-double-u commented May 27, 2021 •
edited
Loading

new log looks good too, I'm impressed at how quick a check it is. 2.0~ seconds.

@chalin chalin mentioned this pull request May 27, 2021
Closed
@nate-double-u nate-double-u mentioned this pull request May 27, 2021
Closed
NotAwar pushed a commit to NotAwar/website that referenced this pull request Feb 27, 2025
@chalin
Reinstate link checking for preview builds (etcd-io#336)
c3f90a6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nate-double-u nate-double-u nate-double-u approved these changes

Assignees

No one assigned

Labels

infrastructure Categorizes issue or PR as related to site infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chalin @nate-double-u