Skip to content

Install page updates for versions older than 'next'#333

Merged
chalin merged 3 commits intomainfrom
318-install-page
May 27, 2021
Merged

Install page updates for versions older than 'next'#333
chalin merged 3 commits intomainfrom
318-install-page

Conversation

@nate-double-u
Copy link
Copy Markdown
Contributor

  • Updating dl-bulid Install page from reworked next dl-build page
  • Renaming file and adding redirect rule
  • adding "Install" to top nav
  • Renaming all dl_build pages to install, so that the versions menu will work more smoothly; adding redirect rules

fixes #318

@nate-double-u
Copy link
Copy Markdown
Contributor Author

nate-double-u commented May 27, 2021

* Updating dl-bulid Install page from reworked next dl-build page
* Renaming file and adding redirect rule
* adding "Install" to top nav
* Renaming all dl_build pages to install, so that the versions menu will work more smoothly; adding redirect rules

Signed-off-by: Nate W <4453979+nate-double-u@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comments.

Signed-off-by: Nate W <4453979+nate-double-u@users.noreply.github.com>
@chalin
Copy link
Copy Markdown
Contributor

chalin commented May 27, 2021

Hmm, could you also change the page titles of v3.3, 3.2, 3.1 from Download and build to Install. (I know that wasn't part of the original #318 description. Thanks)

@nate-double-u
Copy link
Copy Markdown
Contributor Author

nate-double-u commented May 27, 2021

I can do that, I had left them because there was no other content changes.

Signed-off-by: Nate W <4453979+nate-double-u@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (once the build finishes)

@chalin chalin merged commit 103c940 into main May 27, 2021
@nate-double-u nate-double-u deleted the 318-install-page branch May 27, 2021 22:54
NotAwar pushed a commit to NotAwar/website that referenced this pull request Feb 27, 2025
* Install page updates for versions older than 'next'
* Updating dl-bulid Install page from reworked next dl-build page
* Renaming file and adding redirect rule
* adding "Install" to top nav
* Renaming all dl_build pages to install, so that the versions menu will work more smoothly; adding redirect rules

Signed-off-by: Nate W <4453979+nate-double-u@users.noreply.github.com>

* updates based on PR feedback

Signed-off-by: Nate W <4453979+nate-double-u@users.noreply.github.com>

* updating page titles based on PR feedback

Signed-off-by: Nate W <4453979+nate-double-u@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Install page: create from reworked download-and-build

2 participants