Installation page (docs/next) from reworked download page#294
Merged
Conversation
a40933d to
3b9200a
Compare
nate-double-u
approved these changes
May 20, 2021
Contributor
There was a problem hiding this comment.
This looks good to me, it's a good cleanup of the page. I like that you're omiting etcdctl and pointing back to the Quickstart.
I'd be happy to close #288 in favour of this PR.
Next steps questions
- should this file be renamed and a forward added?
- should this file be duplicated into
v3.4?
Contributor
Author
|
@nate-double-u: yes the plan is to rename the file and add a redirect rule, but only in a followup PR. Ditto for v3.4 -- let's get this version approved first so that we don't have to make edits in two places. |
3b9200a to
c06d950
Compare
c06d950 to
ed176e8
Compare
Contributor
Author
|
Hi all: we're coming on a week tomorrow for this PR, so if there are no objections by EOD today, I'll assume that this is good to go. If you need more time, let me know. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preview: https://deploy-preview-294--etcd.netlify.app/docs/next/dl-build/
@spzala @ptabor @gyuho PTAL -- btw, are there plans to support installation using
go install?