Installation page for etcd / etcdctl (update from dl-build)#288
Closed
nate-double-u wants to merge 1 commit intomainfrom
Closed
Installation page for etcd / etcdctl (update from dl-build)#288nate-double-u wants to merge 1 commit intomainfrom
nate-double-u wants to merge 1 commit intomainfrom
Conversation
nate-double-u
commented
May 18, 2021
Comment on lines
+48
to
+51
| ```sh | ||
| $ go get -v go.etcd.io/etcd/v3 | ||
| $ go get -v go.etcd.io/etcd/v3/etcdctl | ||
| ``` |
Contributor
Author
Contributor
Author
There was a problem hiding this comment.
this is currently what is on the site:
# GOPATH should be set
$ echo $GOPATH
/Users/example/go
$ go get -v go.etcd.io/etcd
$ go get -v go.etcd.io/etcd/etcdctl
But this doesn't generate the bin folder either.
Contributor
Author
There was a problem hiding this comment.
some env info:
➜ ~ go version
go version go1.16.4 linux/amd64
➜ ~ echo $GOPATH
/home/natew-cncf/go
➜ ~ ls ~/go
pkg
Contributor
There was a problem hiding this comment.
@ptabor Should we add etcdutil as well? (newly introduced in 3.5)
e0c9083 to
4681dc9
Compare
chalin
requested changes
May 18, 2021
Contributor
chalin
left a comment
There was a problem hiding this comment.
- AFAICT the changes that you're proposing here to the
dl-build.mdpage (which you've renamed toinstall.md) don't depend on the Quickstart PR. If so, could you resubmit this PR w/o the Quickstart additions/changes? - Also, if you're reworking
dl-build.md, it'll be easier to review if (1) you make the updates todl-build.md, and once those are approved, (2) rename the file and add redirect rule(s) - You'll want to rebase following #274 (or simply pickup the changes).
Contributor
Author
There's a link I had initially planned to make to the new quickstart page, but I agree, this should be rebased onto main.
Good suggestion
Thanks for the feedback, I agree with all this. I opened this PR earlier than I normally would (and as a draft) because I was a little blocked with the Go environment issues. I'll see about cleaning it up. |
08c93e5 to
5213ff0
Compare
Contributor
Author
|
Updated as per @chalin's suggestions. |
Signed-off-by: Nate W <4453979+nate-double-u@users.noreply.github.com>
5213ff0 to
d2bdc6f
Compare
Contributor
|
All: please see #294 for a suggested rework of the |
Contributor
Author
|
Closing in favour of #294 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#267, #278 (comment)
Note, merge #278 first.
First pass at refactoring dl-build into an installation page.
Currently, the only relevant file is
content/en/docs/next/install.mdDeploy preview: https://deploy-preview-288--etcd.netlify.app/docs/next/install/