Skip to content

dl-build: substitute build.sh for deprecated build#274

Merged
nate-double-u merged 4 commits intoetcd-io:mainfrom
fabjan:patch-1
May 18, 2021
Merged

dl-build: substitute build.sh for deprecated build#274
nate-double-u merged 4 commits intoetcd-io:mainfrom
fabjan:patch-1

Conversation

@fabjan
Copy link
Copy Markdown
Contributor

@fabjan fabjan commented May 9, 2021

I just pulled latest master and following the directions gave me a deprecation warning:

$ ./build
\e[91mDEPRECATED!!! Use build.sh script instead.\e[0m

I don't know if the deprecation plan involves something special for Windows, or what the old ./build program did, but the current one just sources ./build.sh after printing the deprecation warning so that's what's in my proposed change.

@nate-double-u
Copy link
Copy Markdown
Contributor

nate-double-u commented May 10, 2021 •
edited
Loading

Hi @fabjan, thanks for this!

Would you be able to update the https://etcd.io/docs/next/dl-build/ file as well? It likely suffers from the same issue.

I'll look into why the deploy preview build failed -- given the changes made I find it a bit surprising that it did.

@fabjan
Copy link
Copy Markdown
Contributor Author

fabjan commented May 11, 2021

@nate-double-u Sure thing! I just clicked the "Edit this page" button on the docs and edited directly GitHub (hence the uninformative branch name as well) so did not look much at the context around the change.

Looks like the preview deploy failed because hugo had problems with some vendored bootstrap files, but I don't know anything about the actions setup here.

@fabjan
Copy link
Copy Markdown
Contributor Author

fabjan commented May 11, 2021

@nate-double-u When fixing I noticed the dl-build guides for all 3.x versions had an unused reference link to the Go install docs. I assumed they were meant to be used for the Go reference earlier in the instructions. If that was incorrect I can revert that change.

@fabjan
Copy link
Copy Markdown
Contributor Author

fabjan commented May 11, 2021 •
edited
Loading

Found this Docsy issue mentioning the exact same error message about Bootstrap: google/docsy#279

@nate-double-u nate-double-u mentioned this pull request May 17, 2021
Closed
@nate-double-u
Copy link
Copy Markdown
Contributor

nate-double-u commented May 18, 2021 •
edited
Loading

@fabjan, @chalin has fixed the preview issues with #274 #289. I expect that this PR would have to be rebased in order to trigger a correct build with the new configuration.

As for the edits to the older version pages (next and v3.4 are current), I tend to prefer to leave them as historic artifacts and really only change them for factual errors (or converting things like old broken links to their archival versions). For instance removing the unused link is probably OK, but I'd prefer not to change where the body copy links to if the link is still working.

@nate-double-u nate-double-u mentioned this pull request May 18, 2021
Merged
fabjan and others added 4 commits May 18, 2021 20:13
@fabjan
dl-build: substitute build.sh for deprecated build
ea34999 
I just pulled latest master and following the directions gave me a deprecation warning:

```shell
$ ./build
\e[91mDEPRECATED!!! Use build.sh script instead.\e[0m
```

I don't know if the deprecation plan involves something special for Windows, or what the old `./build` program did, but the current one just sources `./build.sh` after printing the deprecation warning so that's what's in my proposed change.
@fabjan
dl-build: ./build is deprecated
ca8b2f6
@fabjan
dl-build: fix go install ref-links
d663d5f
@fabjan
revert refactor of old content
408e4e6
nate-double-u
nate-double-u approved these changes May 18, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@nate-double-u nate-double-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fabjan!

@nate-double-u nate-double-u merged commit 96bcec9 into etcd-io:main May 18, 2021
@fabjan fabjan deleted the patch-1 branch May 19, 2021 16:34
NotAwar pushed a commit to NotAwar/website that referenced this pull request Feb 27, 2025
@fabjan
dl-build: substitute build.sh for deprecated build (etcd-io#274)
30e7a3a 
* dl-build: substitute build.sh for deprecated build

I just pulled latest master and following the directions gave me a deprecation warning:

```shell
$ ./build
\e[91mDEPRECATED!!! Use build.sh script instead.\e[0m
```

I don't know if the deprecation plan involves something special for Windows, or what the old `./build` program did, but the current one just sources `./build.sh` after printing the deprecation warning so that's what's in my proposed change.

* dl-build: ./build is deprecated

* dl-build: fix go install ref-links

* revert refactor of old content
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nate-double-u nate-double-u nate-double-u approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fabjan @nate-double-u