Skip to content

Fix preview builds#289

Merged
chalin merged 1 commit intomainfrom
chalin-fix-preview-builds-2021-05-18
May 18, 2021
Merged

Fix preview builds#289
chalin merged 1 commit intomainfrom
chalin-fix-preview-builds-2021-05-18

Conversation

@chalin
Copy link
Copy Markdown
Contributor

@chalin chalin commented May 18, 2021

Fixes #287

@chalin chalin force-pushed the chalin-fix-preview-builds-2021-05-18 branch from 72019cd to 8eca88b Compare May 18, 2021 16:17
@chalin chalin added the infrastructure Categorizes issue or PR as related to site infrastructure. label May 18, 2021
@chalin
Copy link
Copy Markdown
Contributor Author

chalin commented May 18, 2021

Merging now since this fixes preview builds. For an explanation of the source of the problem and the fix, see #287 (comment).

@chalin chalin merged commit dc391aa into main May 18, 2021
@chalin chalin deleted the chalin-fix-preview-builds-2021-05-18 branch May 18, 2021 16:26
@chalin chalin requested a review from nate-double-u May 18, 2021 18:15
Copy link
Copy Markdown
Contributor

@nate-double-u nate-double-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

/approve

@chalin chalin restored the chalin-fix-preview-builds-2021-05-18 branch May 20, 2021 18:04
@chalin chalin deleted the chalin-fix-preview-builds-2021-05-18 branch May 20, 2021 18:04
NotAwar pushed a commit to NotAwar/website that referenced this pull request Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infrastructure Categorizes issue or PR as related to site infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Netlify builds failing on simple changes

2 participants