fix(desktop): cap esbuild at ^0.25.0 so wails dev builds again#4410
Merged
Conversation
#4323 pinned esbuild to 0.28.1 (npm overrides + pnpm-workspace overrides) to pick up the patched release. But vite 6.4.2 depends on esbuild ^0.25.0, and 0.28.1 breaks its dev dependency pre-bundling: every dep using destructuring fails with "Transforming destructuring to the configured target environment is not supported yet", so `wails dev` never starts. The advisory the pin targeted was already fixed in 0.25.0, which vite enforces anyway. Cap the override at ^0.25.0 (>=0.25.0 <0.26.0): still patched, matches vite's own range, and blocks Dependabot from bumping back to 0.28. Resolves to 0.25.12. site/ and workers/ keep 0.28.1 (Astro/Wrangler are unaffected by the vite dev path). package-lock.json is regenerated by npm 11 — reformatting only, no dependency drift beyond esbuild.
jxzhealthy
added a commit
to jxzhealthy/DeepSeek-Reasonix
that referenced
this pull request
Jun 15, 2026
fix(desktop): cap esbuild at ^0.25.0 so `wails dev` builds again (esengine#4410)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
wails devfor the desktop app cannot start. Vite's dev dependencypre-bundling fails for every dependency that uses destructuring:
147 errors → the dev build never compiles, so the window never opens.
Root cause
#4323 pinned
esbuildto0.28.1via overrides in bothdesktop/frontend/package.json(npm) anddesktop/frontend/pnpm-workspace.yaml(pnpm) to pick up the patchedrelease. But vite 6.4.2 depends on
esbuild@^0.25.0. With 0.28.1forced tree-wide, vite hands esbuild its dev
ESBUILD_MODULES_TARGET(
es2020, edge88, firefox78, chrome87, safari14+ thedynamic-import/import-metasupported overrides), and esbuild 0.28rejects that combination.
The production path (
build.target: "es2021") is unaffected, which iswhy CI —
pnpm --dir frontend buildonly — stayed green and thebreakage is dev-only.
The security advisory the pin targeted was fixed in 0.25.0, which
vite already enforces, so the 0.28.1 floor was both unnecessary and
breaking here.
Fix
Cap the desktop override at
^0.25.0(>=0.25.0 <0.26.0):site/andworkers/keep0.28.1— Astro/Wrangler don't hit thevite-6 dev path, so their blast radius stays minimal.
package-lock.jsonis regenerated by npm 11 (reformatting only; verifiedno dependency drift beyond esbuild).
Validation (local, origin/main-v2 tip)
wails dev— now launches ("Compiling application: Done", window opens, hot reload watching)pnpm install --frozen-lockfile✓pnpm typecheck✓pnpm test✓ (tsx runs on esbuild 0.25.12)pnpm build(production) ✓