Pin esbuild to patched version / 固定 esbuild 到安全版本#4323
Merged
Conversation
Pin transitive esbuild resolution to 0.28.1 across the site, crash report worker, and desktop frontend dependency graphs. This addresses the GitHub Advisory Database alerts for vulnerable esbuild versions while avoiding unrelated framework upgrades. Co-authored-by: SivanCola <32437197+SivanCola@users.noreply.github.com>
Collaborator
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
esengine
added a commit
that referenced
this pull request
Jun 15, 2026
#4323 pinned esbuild to 0.28.1 (npm overrides + pnpm-workspace overrides) to pick up the patched release. But vite 6.4.2 depends on esbuild ^0.25.0, and 0.28.1 breaks its dev dependency pre-bundling: every dep using destructuring fails with "Transforming destructuring to the configured target environment is not supported yet", so `wails dev` never starts. The advisory the pin targeted was already fixed in 0.25.0, which vite enforces anyway. Cap the override at ^0.25.0 (>=0.25.0 <0.26.0): still patched, matches vite's own range, and blocks Dependabot from bumping back to 0.28. Resolves to 0.25.12. site/ and workers/ keep 0.28.1 (Astro/Wrangler are unaffected by the vite dev path). package-lock.json is regenerated by npm 11 — reformatting only, no dependency drift beyond esbuild.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
esbuildresolution to0.28.1with npm/pnpm overrides for the site, crash report worker, and desktop frontend.Related PRs
siteandworkers/crash-report.Verification
npm audit --jsoninsite,workers/crash-report, anddesktop/frontendpnpm audit --audit-level lowindesktop/frontendnpm run buildinsitenpm run typecheckinworkers/crash-reportwails generate modulefollowed bynpm run buildindesktop/frontendnpm testindesktop/frontend