Skip to content

Fix CodeGraph idle timeout launch paths / 修复 CodeGraph 启动路径空闲超时#4363

Merged
esengine merged 1 commit into
main-v2from
fix/codegraph-timeout-all-launch-paths
Jun 14, 2026
Merged

Fix CodeGraph idle timeout launch paths / 修复 CodeGraph 启动路径空闲超时#4363
esengine merged 1 commit into
main-v2from
fix/codegraph-timeout-all-launch-paths

Conversation

@SivanCola

@SivanCola SivanCola commented Jun 14, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • add a shared CodeGraph built-in MCP spec helper with the Reasonix daemon idle-timeout env
  • use it for normal boot, token-economy on-demand CodeGraph, and manual CodeGraph MCP reconnects
  • cover the helper plus token-economy and controller launch paths with focused tests

Verification

  • go test ./internal/codegraph -run TestMCPSpecSetsReasonixDaemonIdleTimeout -count=1
  • go test ./internal/boot -run 'TestBuild(CodegraphSetsShortDaemonIdleTimeout|TokenEconomyCodegraphSetsShortDaemonIdleTimeout)' -count=1
  • go test ./internal/control -run TestConnectConfiguredCodegraphSetsShortDaemonIdleTimeout -count=1
  • go test ./internal/codegraph ./internal/boot ./internal/control -count=1
  • git diff --check

Fixes follow-up from #4332 discussion_r3409168127.

@SivanCola SivanCola requested a review from esengine as a code owner June 14, 2026 07:46
@github-actions github-actions Bot added v2 Go rewrite (1.x) — main-v2 branch, active development agent Core agent loop (internal/agent, internal/control) mcp MCP servers / plugins (internal/plugin, codegraph) config Configuration & setup (internal/config) labels Jun 14, 2026
@SivanCola

SivanCola commented Jun 14, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

@SivanCola

SivanCola commented Jun 14, 2026

Copy link
Copy Markdown
Collaborator Author

approve

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Jun 14, 2026

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Swish!

Reviewed commit: a471ad8b83

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@SivanCola SivanCola changed the title fix(codegraph): apply idle timeout to all built-in launch paths Fix CodeGraph idle timeout launch paths / 修复 CodeGraph 启动路径空闲超时 Jun 14, 2026
@esengine esengine merged commit f5698cd into main-v2 Jun 14, 2026
15 checks passed
@esengine esengine deleted the fix/codegraph-timeout-all-launch-paths branch June 14, 2026 13:12
@esengine esengine mentioned this pull request Jun 14, 2026
Merged
esengine pushed a commit that referenced this pull request Jun 14, 2026
@SivanCola
feat(mcp): built-in MCP update flow for CodeGraph (#4370)
f07e908 
Add a CodeGraph built-in MCP update path (reasonix codegraph update) with desktop background checks in notify (default) / download / auto_next_session modes. Downloads verify the asset against SHA256SUMS and sanitize the version before any path/URL use; default notify only surfaces a notice and running MCP sessions are never hot-swapped, so provider-visible tool schemas don't change mid-session. Reconnect adopts the shared codegraph.MCPSpec helper (#4363).

Co-authored-by: SivanCola <32437197+SivanCola@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@esengine esengine Awaiting requested review from esengine esengine is a code owner

Assignees

No one assigned

Labels

agent Core agent loop (internal/agent, internal/control) config Configuration & setup (internal/config) mcp MCP servers / plugins (internal/plugin, codegraph) v2 Go rewrite (1.x) — main-v2 branch, active development

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SivanCola @esengine