Skip to content

Add built-in MCP update flow / 新增内置 MCP 更新流程#4370

Merged
esengine merged 4 commits into
esengine:main-v2from
SivanCola:feature/builtin-mcp-updates
Jun 14, 2026
Merged

Add built-in MCP update flow / 新增内置 MCP 更新流程#4370
esengine merged 4 commits into
esengine:main-v2from
SivanCola:feature/builtin-mcp-updates

Conversation

@SivanCola

Copy link
Copy Markdown
Collaborator

Summary

  • add a CodeGraph built-in MCP update path that downloads latest releases, tracks active runtime versions, and exposes reasonix codegraph update
  • add desktop background built-in MCP update checks with safe modes: notify, download, and auto_next_session
  • surface built-in MCP update status in the desktop MCP manager, while clarifying that Context7 is managed by npx/npm and Time updates with the Reasonix app

Cache and session safety

  • default mode is notify, so Reasonix does not silently switch provider-visible MCP tool schemas
  • download prefetches without activation; auto_next_session activates for future connections only
  • active MCP sessions are not hot-swapped by the background updater

Verification

  • go test ./internal/codegraph ./internal/config ./internal/cli
  • go test ./... from desktop/
  • pnpm --dir desktop/frontend typecheck
  • pnpm --dir desktop/frontend check:css
  • git diff --check
  • browser verification of the MCP manager update notice, CodeGraph upgrade status, and Context7/Time update-source labels

@SivanCola SivanCola requested a review from esengine as a code owner June 14, 2026 09:49
@github-actions github-actions Bot added v2 Go rewrite (1.x) — main-v2 branch, active development desktop Wails desktop app (desktop/**) tui Terminal UI / CLI (internal/cli, internal/control) mcp MCP servers / plugins (internal/plugin, codegraph) config Configuration & setup (internal/config) labels Jun 14, 2026
@SivanCola SivanCola enabled auto-merge June 14, 2026 09:56
@SivanCola

Copy link
Copy Markdown
Collaborator Author

approve

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 57357b0112

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread desktop/builtin_mcp_updates.go Outdated
Comment thread desktop/app.go Outdated
Comment thread internal/config/render.go Outdated
Comment thread desktop/app.go Outdated
Co-authored-by: SivanCola <32437197+SivanCola@users.noreply.github.com>
@github-actions github-actions Bot added the agent Core agent loop (internal/agent, internal/control) label Jun 14, 2026
Co-authored-by: SivanCola <32437197+SivanCola@users.noreply.github.com>
@esengine

Copy link
Copy Markdown
Owner

Reviewed — the update flow is well done. The download path verifies the asset against SHA256SUMS and sanitizes the version before it touches any path/URL, and the mode design keeps things cache-safe: notify (default) only surfaces a notice, download prefetches without activating, and auto_next_session writes the active-version for future sessions only — running MCP sessions aren't hot-swapped, so provider-visible tool schemas don't change mid-session. Nice.

It now conflicts with main-v2 (controller.go and app.go). The controller.go one is from #4363, which just landed: connectCodegraphMCPServer now builds the spec via the shared codegraph.MCPSpec(bin, cwd) helper instead of an inline plugin.Spec. Please merge main-v2 and adopt MCPSpec there (it already carries the idle-timeout env / codegraph_ strip / low-priority you added inline), and reconcile the app.go update wiring. Once it's green I'll merge.

@esengine esengine merged commit f07e908 into esengine:main-v2 Jun 14, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Core agent loop (internal/agent, internal/control) config Configuration & setup (internal/config) desktop Wails desktop app (desktop/**) mcp MCP servers / plugins (internal/plugin, codegraph) tui Terminal UI / CLI (internal/cli, internal/control) v2 Go rewrite (1.x) — main-v2 branch, active development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants