Scope Desktop session runtimes and preserve classic tabs / 会话运行态隔离并保留 classic 顶部标签页#4360
Merged
SivanCola merged 9 commits intoJun 14, 2026
Merged
Conversation
Route Desktop navigation through session-scoped runtimes so switching or hiding views no longer cancels active work, and remove the user-facing top tab strip in favor of the sidebar. Co-authored-by: Cursor <cursoragent@cursor.com>
Drop stale helper functions left behind by the session runtime refactor so desktop lint stays clean. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Add a General settings option for desktop layout style, keeping the classic layout as the default while adding a Codex-inspired workbench sidebar. Implement workbench-only navigation density, project/session quick actions, pinned project and session grouping, and desktop layout persistence. Co-authored-by: SivanCola <32437197+SivanCola@users.noreply.github.com>
Co-authored-by: SivanCola <32437197+SivanCola@users.noreply.github.com>
Co-authored-by: SivanCola <32437197+SivanCola@users.noreply.github.com>
Collaborator
|
approve |
Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
@SivanCola |
Resolve desktop/runtime conflicts while preserving the async Wails event emitter and topic-session index cache. Keep detached runtime telemetry and snapshot ownership on detached runtimes, and restore ClearSession cleanup error propagation. Co-authored-by: SivanCola <32437197+SivanCola@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
本 PR 已按新的合并顺序整改：先合 #4369 的 workbench 桌面风格，再合本 PR 的 session runtime 修正。因此它不再把“移除顶部 Tab”作为 classic 的目标。
当前语义：
sessionPath为身份，左侧会话栏可以打开具体 session，切换/隐藏视图不会隐式取消、混用或丢失另一个 session 的 controller/runtime。Relationship With #4369
#4369 是前置布局改动。本 PR 当前 head 已合入 #4369，并解决两边冲突：
TabBar，并让AppChrome只在 classic 分支渲染它。workbenchChrome分支只保留 workbench 搜索入口和窗口 chrome，不渲染 classic 顶部 session tab strip。sessionPathruntime session 节点。Test Plan
pnpm --dir desktop/frontend typecheckpnpm --dir desktop/frontend testpnpm --dir desktop/frontend buildpnpm --dir desktop/frontend check:cssgo test ./internal/configcd desktop && go test .git diff --cached --check127.0.0.1: classic has one.app-chrome__tab-strip/.tabbar; workbench has.app--workbench, zero.app-chrome__tab-strip, zero.tabbar, and one.app-chrome__workbench-search.Notes
The build still emits the existing Vite warnings about mixed static/dynamic import of
bridge.tsand large chunks; the build completes successfully.