Skip to content

Add switchable desktop workbench layout / 新增可切换工作台桌面风格#4369

Merged
esengine merged 5 commits into
main-v2from
feature/desktop-workbench-style
Jun 14, 2026
Merged

Add switchable desktop workbench layout / 新增可切换工作台桌面风格#4369
esengine merged 5 commits into
main-v2from
feature/desktop-workbench-style

Conversation

@SivanCola

@SivanCola SivanCola commented Jun 14, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Add a General settings desktop layout style option with classic as the default and a new workbench style.
  • Add a Codex-inspired workbench sidebar with compact project grouping, project/session quick actions, pinned grouping, archive behavior, and aligned chrome controls.
  • Persist project and topic pinned state across desktop settings/config with focused tests.

Verification

  • npm run typecheck
  • npm run check:css
  • go test . in the desktop module
  • go test ./internal/config
  • git diff --check origin/main-v2...HEAD
  • Browser DOM verification for classic and workbench chrome toggle alignment

Authorship note: @SivanCola contributed as a collaborator by shaping the workbench design, reviewing iterations, and verifying the final behavior.

@SivanCola
feat(desktop): add switchable workbench layout
04c2eb0 
Add a General settings option for desktop layout style, keeping the classic layout as the default while adding a Codex-inspired workbench sidebar.

Implement workbench-only navigation density, project/session quick actions, pinned project and session grouping, and desktop layout persistence.

Co-authored-by: SivanCola <32437197+SivanCola@users.noreply.github.com>
@SivanCola SivanCola requested a review from esengine as a code owner June 14, 2026 09:48
@github-actions github-actions Bot added desktop Wails desktop app (desktop/**) config Configuration & setup (internal/config) v2 Go rewrite (1.x) — main-v2 branch, active development labels Jun 14, 2026
chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Jun 14, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 04c2eb0694

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread desktop/frontend/src/components/ProjectTree.tsx
@SivanCola
fix(desktop): expose workbench time filter
97ccf1c 
Co-authored-by: SivanCola <32437197+SivanCola@users.noreply.github.com>
@SivanCola SivanCola enabled auto-merge June 14, 2026 10:46
@SivanCola

SivanCola commented Jun 14, 2026

Copy link
Copy Markdown
Collaborator Author

approve

@SivanCola SivanCola mentioned this pull request Jun 14, 2026
Merged
@esengine

esengine commented Jun 14, 2026

Copy link
Copy Markdown
Owner

Reviewed — the layout-style config (default classic, UI-only, round-trip + migration tested) and the pinned project/topic persistence (backward-compatible, dedupes, drops stale pins) look solid, and the workbench sidebar is a nice build.

It conflicts with main-v2 though, and the one conflict (in App.tsx) is a semantic one I'd rather you resolve since you own both sides: this branch refactored the sidebar IM block into a sidebarImBlock variable, while main-v2 (from the QQ work in #4324) edited the inline block. Heads-up that the refactored sidebarImBlock here still has the platform badge as weixin ? "微" : lark ? "L" : "飞" — it's missing the qq ? "Q" case that landed on main-v2, so a straight "take ours" would drop the QQ sidebar badge. Could you merge main-v2 and fold the current IM-block state (QQ badge etc.) into sidebarImBlock? Once it's green I'll merge.

codex and others added 2 commits June 14, 2026 21:25
@codex @SivanCola
Merge main-v2 into desktop workbench style
aa03114 
Co-authored-by: SivanCola <32437197+SivanCola@users.noreply.github.com>
@codex @SivanCola
Merge main-v2 into desktop workbench style
892b8ab 
Co-authored-by: SivanCola <32437197+SivanCola@users.noreply.github.com>
@SivanCola

SivanCola commented Jun 14, 2026

Copy link
Copy Markdown
Collaborator Author

Done in 892b8ab. I merged the latest main-v2 into this branch and rechecked the extracted sidebarImBlock; the platform badge preserves the QQ case (qq => Q) before the Weixin/Lark/Feishu fallbacks.

Verification:

  • go test ./...
  • go test ./... from desktop/
  • npm --prefix desktop/frontend run build
  • npm --prefix desktop/frontend test
  • GitHub checks: all passing on 892b8ab

@SivanCola SivanCola disabled auto-merge June 14, 2026 13:53
@SivanCola SivanCola enabled auto-merge June 14, 2026 13:55
@esengine esengine merged commit a6aae98 into main-v2 Jun 14, 2026
13 checks passed
@esengine esengine deleted the feature/desktop-workbench-style branch June 14, 2026 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments

@esengine esengine Awaiting requested review from esengine esengine is a code owner

Assignees

No one assigned

Labels

config Configuration & setup (internal/config) desktop Wails desktop app (desktop/**) v2 Go rewrite (1.x) — main-v2 branch, active development

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SivanCola @esengine @codex