refactor(desktop): extract goal-draft collaboration-mode helpers#3802
Merged
Conversation
The goal-draft decision was inlined at seven App.tsx call sites (active tab, tab list, controller sync, model switch). Move it into src/lib/goalDraftMode.ts so the rule lives in one place and is unit tested; no behavior change from the inline form merged in #3795. Co-authored-by: SivanCola <32437197+SivanCola@users.noreply.github.com>
SuMuxi66
pushed a commit
to SuMuxi66/DeepSeek-Reasonix
that referenced
this pull request
Jun 10, 2026
…ngine#3802) The goal-draft decision was inlined at seven App.tsx call sites (active tab, tab list, controller sync, model switch). Move it into src/lib/goalDraftMode.ts so the rule lives in one place and is unit tested; no behavior change from the inline form merged in esengine#3795. Co-authored-by: reasonix <reasonix@deepseek.com> Co-authored-by: SivanCola <32437197+SivanCola@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal-draft collaboration-mode decision was inlined at seven call
sites in
App.tsx(active tab, tab list, controller sync, model switch).This pulls the rule into
src/lib/goalDraftMode.tsas five small purefunctions and adds unit coverage in
goal-draft-mode.test.ts.No behavior change — the helpers are equivalent to the inline form
merged in #3795. The point is to keep the decision in one place and make
it testable.
The helper extraction and tests were originally proposed by @SivanCola
in #3794 (co-authored here). The handoff fix itself already landed
inline via #3795, so this PR carries only the refactor + tests.