Skip to content

Fix draft goal mode handoff / 修复目标草稿模式切换#3794

Closed
SivanCola wants to merge 1 commit into
esengine:main-v2from
SivanCola:codex/fix-goal-draft-main
Closed

Fix draft goal mode handoff / 修复目标草稿模式切换#3794
SivanCola wants to merge 1 commit into
esengine:main-v2from
SivanCola:codex/fix-goal-draft-main

Conversation

@SivanCola

@SivanCola SivanCola commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Follow-up to Refresh desktop themeable workspace UI / 刷新桌面主题化工作区界面 #3752 for fixes that landed after the merge into main-v2.
  • Replace the Composer collaboration menu entry from a plus icon / generic actions label to a sliders icon / collaboration-mode label.
  • Preserve draft goal mode locally while the goal text is empty, while syncing the controller as normal mode until a real goal starts.
  • Extract goal draft mode decisions into small helpers and add a regression test for the flicker/disappearing capsule case.

Verification

  • wails generate module
  • pnpm --dir desktop/frontend typecheck
  • pnpm --dir desktop/frontend test:typecheck
  • pnpm --dir desktop/frontend test
  • pnpm --dir desktop/frontend check:browser-preview
  • pnpm --dir desktop/frontend build

Cache safety

  • Frontend UI state, icon/copy, and tests only; no provider request serialization, tool schema, prompt prefix, or cache-sensitive surface changed.

@SivanCola SivanCola requested a review from esengine as a code owner June 10, 2026 06:14
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Jun 10, 2026

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

1 similar comment
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Jun 10, 2026

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@github-actions github-actions Bot added the desktop Wails desktop app (desktop/**) label Jun 10, 2026
@github-actions github-actions Bot added the v2 Go rewrite (1.x) — main-v2 branch, active development label Jun 10, 2026
@SivanCola SivanCola force-pushed the codex/fix-goal-draft-main branch from ae5d4e2 to 73da035 Compare June 10, 2026 06:16
esengine
esengine approved these changes Jun 10, 2026
View reviewed changes

@esengine esengine left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch on the goal draft handoff. Merging.

@esengine esengine mentioned this pull request Jun 10, 2026
Merged
@esengine

esengine commented Jun 10, 2026

Copy link
Copy Markdown
Owner

Thanks for this, @SivanCola — and sorry for the churn.

This and #3795 implement the same goal-draft handoff fix (the mode helpers here are equivalent to the inline version in #3795). To avoid rewriting the just-merged logic, I've split your helper extraction + unit tests into a standalone refactor in #3802, co-authored to you.

Closing as superseded by #3795 (the fix) + #3802 (helpers/tests). The handoff behavior you fixed is shipping. 🙏

@esengine esengine closed this Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@esengine esengine esengine approved these changes

Assignees

No one assigned

Labels

desktop Wails desktop app (desktop/**) v2 Go rewrite (1.x) — main-v2 branch, active development

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SivanCola @esengine