test: fix staticcheck SA5011 false-positive failing lint on all PRs#3706
Merged
Conversation
The release golangci-lint v2.12.2 binary CI runs flags SA5011 (possible nil
pointer dereference) on two `if x == nil { t.Fatal(...) }`-guarded derefs,
even though they are correct (Fatal stops the test). The finding was masked by
the golangci-lint-action cache until #3678 changed go.sum and invalidated it,
then surfaced on main-v2 and every open PR. A locally-built golangci-lint does
not reproduce it, so this is a staticcheck quirk in the pinned binary, not a
real defect.
Restructure both sites with flow-based guards (else-if / switch) the analyzer
always respects — no behaviour change, no unreachable `return` (which a
Fatal-aware analyzer would flag locally).
6d1ddec to
1cc9289
Compare
esengine
pushed a commit
that referenced
this pull request
Jun 9, 2026
The release golangci-lint binary CI runs flags SA5011 on guarded t.Fatal derefs in backfill_test.go and migrate_test.go (same cache-masked false positive as #3706); this PR touches the config package so a cold lint run surfaces them. Guard with else-if; no behavior change.
esengine
added a commit
that referenced
this pull request
Jun 9, 2026
…#3635) (#3714) * fix(config): honor an explicit proxy for no_proxy providers (mimo) The built-in mimo presets carry no_proxy=true so their domestic endpoint stays off an auto-detected (GFW-circumvention) system proxy. But that bypass was applied in every mode, so behind a mandatory corporate proxy (proxy_mode = "custom") mimo tried a direct connection the firewall blocks — making mimo unusable on enterprise networks (#3635). Apply the provider-level no_proxy bypass only for auto/env proxies. An explicit custom proxy means "route everything through this", so honor it for every provider; a custom-proxy user who still wants a host direct uses network.no_proxy. Closes #3635 * test(config): structurally guard nil-deref (staticcheck SA5011) The release golangci-lint binary CI runs flags SA5011 on guarded t.Fatal derefs in backfill_test.go and migrate_test.go (same cache-masked false positive as #3706); this PR touches the config package so a cold lint run surfaces them. Guard with else-if; no behavior change. --------- Co-authored-by: reasonix <reasonix@deepseek.com>
esengine
added a commit
that referenced
this pull request
Jun 9, 2026
The pinned golangci-lint binary's staticcheck reports SA5011 (possible nil
pointer dereference) on `if x == nil { t.Fatal(...) }`-guarded derefs in tests
— it doesn't model t.Fatal as terminating. The same code is clean under a
locally-built golangci-lint, and the finding is masked by the action cache
until a go.sum change cold-busts it, so it surfaces per-package and has failed
lint on otherwise-correct PRs (handled ad hoc in #3706, #3714).
Scope a test-only SA5011 exclusion so it stops blocking PRs while SA5011 keeps
guarding production code.
Co-authored-by: reasonix <reasonix@deepseek.com>
SuMuxi66
pushed a commit
to SuMuxi66/DeepSeek-Reasonix
that referenced
this pull request
Jun 10, 2026
esengine#3706) The release golangci-lint v2.12.2 binary CI runs flags SA5011 (possible nil pointer dereference) on two `if x == nil { t.Fatal(...) }`-guarded derefs, even though they are correct (Fatal stops the test). The finding was masked by the golangci-lint-action cache until esengine#3678 changed go.sum and invalidated it, then surfaced on main-v2 and every open PR. A locally-built golangci-lint does not reproduce it, so this is a staticcheck quirk in the pinned binary, not a real defect. Restructure both sites with flow-based guards (else-if / switch) the analyzer always respects — no behaviour change, no unreachable `return` (which a Fatal-aware analyzer would flag locally). Co-authored-by: reasonix <reasonix@deepseek.com>
SuMuxi66
pushed a commit
to SuMuxi66/DeepSeek-Reasonix
that referenced
this pull request
Jun 10, 2026
…esengine#3635) (esengine#3714) * fix(config): honor an explicit proxy for no_proxy providers (mimo) The built-in mimo presets carry no_proxy=true so their domestic endpoint stays off an auto-detected (GFW-circumvention) system proxy. But that bypass was applied in every mode, so behind a mandatory corporate proxy (proxy_mode = "custom") mimo tried a direct connection the firewall blocks — making mimo unusable on enterprise networks (esengine#3635). Apply the provider-level no_proxy bypass only for auto/env proxies. An explicit custom proxy means "route everything through this", so honor it for every provider; a custom-proxy user who still wants a host direct uses network.no_proxy. Closes esengine#3635 * test(config): structurally guard nil-deref (staticcheck SA5011) The release golangci-lint binary CI runs flags SA5011 on guarded t.Fatal derefs in backfill_test.go and migrate_test.go (same cache-masked false positive as esengine#3706); this PR touches the config package so a cold lint run surfaces them. Guard with else-if; no behavior change. --------- Co-authored-by: reasonix <reasonix@deepseek.com>
SuMuxi66
pushed a commit
to SuMuxi66/DeepSeek-Reasonix
that referenced
this pull request
Jun 10, 2026
…ne#3715) The pinned golangci-lint binary's staticcheck reports SA5011 (possible nil pointer dereference) on `if x == nil { t.Fatal(...) }`-guarded derefs in tests — it doesn't model t.Fatal as terminating. The same code is clean under a locally-built golangci-lint, and the finding is masked by the action cache until a go.sum change cold-busts it, so it surfaces per-package and has failed lint on otherwise-correct PRs (handled ad hoc in esengine#3706, esengine#3714). Scope a test-only SA5011 exclusion so it stops blocking PRs while SA5011 keeps guarding production code. Co-authored-by: reasonix <reasonix@deepseek.com>
dorokuma
pushed a commit
to dorokuma/DeepSeek-Reasonix
that referenced
this pull request
Jun 10, 2026
…esengine#3635) (esengine#3714) * fix(config): honor an explicit proxy for no_proxy providers (mimo) The built-in mimo presets carry no_proxy=true so their domestic endpoint stays off an auto-detected (GFW-circumvention) system proxy. But that bypass was applied in every mode, so behind a mandatory corporate proxy (proxy_mode = "custom") mimo tried a direct connection the firewall blocks — making mimo unusable on enterprise networks (esengine#3635). Apply the provider-level no_proxy bypass only for auto/env proxies. An explicit custom proxy means "route everything through this", so honor it for every provider; a custom-proxy user who still wants a host direct uses network.no_proxy. Closes esengine#3635 * test(config): structurally guard nil-deref (staticcheck SA5011) The release golangci-lint binary CI runs flags SA5011 on guarded t.Fatal derefs in backfill_test.go and migrate_test.go (same cache-masked false positive as esengine#3706); this PR touches the config package so a cold lint run surfaces them. Guard with else-if; no behavior change. --------- Co-authored-by: reasonix <reasonix@deepseek.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What broke
Since the Dependabot cluster landed (~11:51 today), lint fails on main-v2's PRs and every open PR with
staticcheck SA5011(possible nil pointer dereference):Both sites are correctly guarded (
if x == nil { t.Fatal(...) }then deref).Root cause
The release golangci-lint v2.12.2 binary that CI runs flags SA5011 on these guarded derefs — a staticcheck quirk in that prebuilt binary. The finding was masked by the golangci-lint-action cache until #3678 changed
go.sumand invalidated it, after which it surfaced on main-v2 and every PR. A locally-built golangci-lint v2.12.2 (whole module,GOOS=linux, fresh GOCACHE + lint cache) does not reproduce it, so this is not a real defect.Fix
Restructure both sites with flow-based guards (
else if/switch) that staticcheck always respects. No behaviour change (both were fatal — first failure stops the test) and no unreachablereturn(which a Fatal-aware analyzer would flag locally). Source/action versions untouched.Note
Each PR runs ci.yml from its own branch, so open PRs only need a rebase onto this once merged to go green — they don't carry these test files' fix until then. (The two files are unrelated to most PRs' changes.)